Bug 1225648

Summary:	Review Request: compat-libvpx1 - Compat package with libvpx libraries
Product:	[Fedora] Fedora	Reporter:	Kalev Lember <kalevlember>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	klember, mjuszkie, package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	compat-libvpx1-1.3.0-2.fc23	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-07-27 09:00:46 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kalev Lember 2015-05-27 21:34:57 UTC

Spec URL: https://kalev.fedorapeople.org/compat-libvpx1.spec
SRPM URL: https://kalev.fedorapeople.org/compat-libvpx1-1.3.0-1.fc23.src.rpm
Description:
This is an ABI compatibility package for 3rd party programs that don't follow Fedora release schedule closely. The intention is to keep this package during the F23 lifetime to give 3rd parties time to rebuild their stuff, and retire and obsolete it in F24.

Fedora Account System Username: kalev

Comment 1 Kalev Lember 2015-05-27 21:37:02 UTC

For reference, here's the diff to the F22 libvpx package: http://paste.fedoraproject.org/226292

I'd like to keep the diff to the original package down to the minimum in order to be able to easily share fixes when needed, so if possible please don't pick on the indentation and things like that that are also present in the original F22 package.

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9858842

Comment 2 Marcin Juszkiewicz 2015-05-28 07:05:17 UTC

VirtualBox is a great example. rpmfusion is another user of this package.

Comment 3 Zbigniew Jędrzejewski-Szmek 2015-07-16 15:18:14 UTC

Issues:
=======
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros

I guess that you might want to change that in libvpx first to keep differences to minimum.

- URL is wrong:
compat-libvpx1.i686: W: invalid-url URL: http://www.webmproject.org/tools/vp8-sdk/ HTTP Error 404: Not Found

- formatting:
compat-libvpx1.src:120: W: macro-in-comment %doc
compat-libvpx1.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 5)

Rest of rpmlint output (nothing interesting):
compat-libvpx1.i686: W: no-documentation
compat-libvpx1.i686: E: non-standard-executable-perm /usr/lib/libvpx.so.1.3.0 0775L
srpm/compat-libvpx1.spec:61: W: configure-without-libdir-spec
srpm/compat-libvpx1.spec:63: W: configure-without-libdir-spec

Please fix those minor issues at your convenience. Package is APPROVED.

Comment 4 Kalev Lember 2015-07-17 10:20:11 UTC

Nice, thanks Zbigniew! I'll fix these up in both libvpx and the new compat package.

Comment 5 Kalev Lember 2015-07-17 10:23:46 UTC

New Package SCM Request
=======================
Package Name: compat-libvpx1
Short Description: Compat package with libvpx libraries
Upstream URL: http://www.webmproject.org/code/
Owners: kalev
Branches: f23
InitialCC:

Comment 6 Kevin Fenzi 2015-07-20 16:50:12 UTC

Git done (by process-git-requests).

Comment 7 Kalev Lember 2015-07-27 09:00:46 UTC

Package imported and built.

I've fixed up the issues you pointed out in both libvpx and compat-libvpx1, thanks again!

http://pkgs.fedoraproject.org/cgit/libvpx.git/commit/?id=c5f11b0e79d35cdb81f4f4f25010d001428b7de9
http://pkgs.fedoraproject.org/cgit/compat-libvpx1.git/commit/?id=2d0cd27935d3f62fccb536b3938c0fcb2b15018c