Bug 1225728

Just a note: in order for this change not to break a regular vdsm installation, we need the updated gluster packages in the RHEL channel.

Is this acked by RHGS dev/PMs?

(In reply to Allon Mureinik from comment #1)
> Just a note: in order for this change not to break a regular vdsm
> installation, we need the updated gluster packages in the RHEL channel.
> 
> Is this acked by RHGS dev/PMs?

We had a discussion on this.
The package will be built and delivered in RHEV, but the requirement for gluster server packages will be removed. Host deploy will install the packages on the host, if the channel is available. We need to make sure that Gluster packages fail nicely, if gluster action are ran and daemon is not installed.

(In reply to Sahina Bose from comment #0)
Sahina, vdsm needs both glusterfs-cli (for /usr/sbin/gluster) and glusterfs-fuse (for /usr/sbin/mount.glusterfs), and parts from the vdsm-gluster package, implementing the gluster apis (such as glusterVolumeInfo).

These are required in any installation - not only HC - to support gluster disk using libvirt network disk, and verifying and manipulating the gluster command line options.

See the gluster-rfe patches:
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:gluster-rfe

Maybe the vdsm-gluster package should be broken to vdsm-gluster-client and vdsm-gluster-server?

Darshan has posted a WIP patch to do this -  https://gerrit.ovirt.org/#/c/41568

(In reply to Sahina Bose from comment #4)
> Darshan has posted a WIP patch to do this - 
> https://gerrit.ovirt.org/#/c/41568

This seems like the right direction, thanks!

Ala, can you check your patches on top of Darshan patch and see if it 
works for us?

This needinfo is not relevant anymore

Ala/Nir, please include the correct patches in the trackers

(In reply to Tal Nisan from comment #7)
> Ala/Nir, please include the correct patches in the trackers

What is wrong with the current patches?

Is there anything pending from gluster side?
Regarding comment 2 - "We need to make sure that Gluster packages fail nicely, if gluster action are ran and daemon is not installed."
- if vdsm-gluster is not installed, the vdsm gluster commands currently fail with a generic gluster exception. Is there a change required here?

Can we make this happen in 4.0 ?

Nir - who is handling this one?

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

(In reply to Oved Ourfali from comment #11)
> Nir - who is handling this one?

Allon?

(In reply to Yaniv Dary from comment #2)
> (In reply to Allon Mureinik from comment #1)
> > Just a note: in order for this change not to break a regular vdsm
> > installation, we need the updated gluster packages in the RHEL channel.
> > 
> > Is this acked by RHGS dev/PMs?
> 
> We had a discussion on this.
> The package will be built and delivered in RHEV, but the requirement for
> gluster server packages will be removed. Host deploy will install the
> packages on the host, if the channel is available. We need to make sure that
> Gluster packages fail nicely, if gluster action are ran and daemon is not
> installed.
They do.
Handling host deploy to bring the gluster packages in an HC usecase is up to gluster's engineering if they think it's crucial.

oVirt 4.0 Alpha has been released, moving to oVirt 4.0 Beta target.

https://gerrit.ovirt.org/57862 - has been posted to install glusterfs packages as part of host-deploy.

What's next in terms of getting this package build as part of RHEV?

(In reply to Sahina Bose from comment #18)
> https://gerrit.ovirt.org/57862 - has been posted to install glusterfs
> packages as part of host-deploy.
> 
> What's next in terms of getting this package build as part of RHEV?

Eyal - please work with Sahina to make it happen.

I'm not a vdsm maintainer so I wouldn't know what exactly is needed.
The spec file for upstream vdsm needs to be updated to support it and the build script that we use also will need updating, i think it's autobuild.sh.

Yaniv B, the downstream VDSM maintainer should be able to assist.
Also once its built we'll need to add it to the content listing of packages to ship, but that will only happen for 4.1 or 4.0.z

We need to:
1. build d/s with --enable-gluster-mgmt, so RHEV has the gluster code
2. modify vdsm.spec so that vdsm.rpm can install without glusterfs-cli
3. pull glusterfs-cli and glusterfs-fuse during o-h-d of hyper-coverge.

these actions would let us have a single vdsm build that can (1) ship without gluster in RHEV channel and (2) provide gluster-management and gluster SD consumption in hyperconverge channel.

(In reply to Dan Kenigsberg from comment #21)
> We need to:
> 1. build d/s with --enable-gluster-mgmt, so RHEV has the gluster code
> 2. modify vdsm.spec so that vdsm.rpm can install without glusterfs-cli

You mean, modify vdsm.spec without glusterfs-server, right?
glusterfs-cli and glusterfs-fuse are required for using gluster as storage domain, i.e without vdsm-gluster and is part of RHEL (optional) channels.

> 3. pull glusterfs-cli and glusterfs-fuse during o-h-d of hyper-coverge.
> 
> these actions would let us have a single vdsm build that can (1) ship
> without gluster in RHEV channel and (2) provide gluster-management and
> gluster SD consumption in hyperconverge channel.

Why can't we create a sub package that will require the gluster bits only if installed?

Moving to modified as the patch is present in vdsm tag 4.18.7

Tested with RHV 4.0.2-6 and I see that the vdsm-gluster package is now available

[root@ ~]# yum list vdsm-gluster
Loaded plugins: product-id, search-disabled-repos, subscription-manager
Installed Packages
vdsm-gluster.noarch  4.18.11-1.el7ev   @rhel-7-server-rhv-4-mgmt-agent-beta-rpms

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-1671.html