Bug 1225793

Summary:	Spurious failure in tests/bugs/disperse/bug-1161621.t
Product:	[Community] GlusterFS	Reporter:	Xavi Hernandez <jahernan>
Component:	disperse	Assignee:	Xavi Hernandez <jahernan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs
Target Milestone:	---	Keywords:	Reopened, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1225796 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:06:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1225796, 1226147

Description Xavi Hernandez 2015-05-28 09:17:18 UTC

Description of problem:

Occasionally this tests fails:

[07:31:15] ./tests/bugs/disperse/bug-1161621.t .. 15/16 
not ok 15 Got "e98ab0b83418491d10e154bf2da4ed04c51576c7" instead of "faa724f45d035ae99d24842a0c32a6463e9cbdbe"

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2015-05-28 15:02:05 UTC

REVIEW: http://review.gluster.org/10974 (cluster/ec: Ignore differences in non locked inodes) posted (#1) for review on master by Xavier Hernandez (xhernandez)

Comment 2 Anand Avati 2015-05-28 15:54:03 UTC

REVIEW: http://review.gluster.org/10974 (cluster/ec: Ignore differences in non locked inodes) posted (#2) for review on master by Xavier Hernandez (xhernandez)

Comment 3 Anand Avati 2015-05-30 12:35:40 UTC

COMMIT: http://review.gluster.org/10974 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 90ed7128dfd4d10e65efcc866cfd610ba3b0cc30
Author: Xavier Hernandez <xhernandez>
Date:   Thu May 28 16:54:59 2015 +0200

    cluster/ec: Ignore differences in non locked inodes
    
    When ec combines iatt structures from multiple bricks, it checks
    for equality in important fields. This is ok for iatt related to
    inodes involved in the operation that have been locked before
    starting execution. However some fops return iatt information
    from other inodes. For example a rename locks source and destination
    parent directories, but it also returns an iatt from the entry
    itself.
    
    In these cases we ignore differences in some fields to avoid false
    detection of inconsistencies and trigger unnecessary self-heals.
    
    Another issue is solved in this patch that caused that the real
    size of the file stored into the inode context was lost during
    self-heal.
    
    Change-Id: I8b8eca30b2a6c39c7b9bbd3b3b6ba95228fcc041
    BUG: 1225793
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: http://review.gluster.org/10974
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: NetBSD Build System

Comment 4 Anand Avati 2015-05-31 17:59:00 UTC

REVIEW: http://review.gluster.org/11018 (cluster/ec: Fix incorrect check for iatt differences) posted (#1) for review on master by Xavier Hernandez (xhernandez)

Comment 5 Anand Avati 2015-06-02 13:58:35 UTC

REVIEW: http://review.gluster.org/11018 (cluster/ec: Fix incorrect check for iatt differences) posted (#2) for review on master by Xavier Hernandez (xhernandez)

Comment 6 Anand Avati 2015-06-02 14:43:42 UTC

REVIEW: http://review.gluster.org/11049 (cluster/ec: Fix incorrect check for iatt differences) posted (#1) for review on release-3.7 by Xavier Hernandez (xhernandez)

Comment 7 Nagaprasad Sathyanarayana 2015-10-25 14:42:53 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 8 Niels de Vos 2016-06-16 13:06:19 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user