Bug 1226005

Summary:	should not spawn another migration daemon on graph switch
Product:	[Community] GlusterFS	Reporter:	Dan Lambright <dlambrig>
Component:	tiering	Assignee:	Dan Lambright <dlambrig>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	high	Docs Contact:
Priority:	high
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1227469 1259078 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:06:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1227469, 1259078, 1260923

Description Dan Lambright 2015-05-28 17:49:14 UTC

When we did a graph switch on a rebalance daemon, a second call to gf_degrag_start() was done. This lead to multiple threads doing migration. When multiple threads try to move the same file there can be deadlocks.

Comment 1 Anand Avati 2015-05-28 18:01:39 UTC

REVIEW: http://review.gluster.org/10977 (When we did a graph switch on a rebalance daemon, a second call to gf_degrag_start() was done. This lead to multiple threads doing migration. When multiple threads try to move the same file there can be deadlocks.) posted (#1) for review on master by Dan Lambright (dlambrig)

Comment 2 Anand Avati 2015-05-28 21:29:10 UTC

REVIEW: http://review.gluster.org/10977 (When we did a graph switch on a rebalance daemon, a second call to gf_degrag_start() was done. This lead to multiple threads doing migration. When multiple threads try to move the same file there can be deadlocks.) posted (#3) for review on master by Dan Lambright (dlambrig)

Comment 3 Anand Avati 2015-05-29 19:56:51 UTC

REVIEW: http://review.gluster.org/10977 (When we did a graph switch on a rebalance daemon, a second call to gf_degrag_start() was done. This lead to multiple threads doing migration. When multiple threads try to move the same file there can be deadlocks.) posted (#4) for review on master by Dan Lambright (dlambrig)

Comment 4 Anand Avati 2015-05-30 10:34:53 UTC

REVIEW: http://review.gluster.org/10977 (When we did a graph switch on a rebalance daemon, a second call to gf_degrag_start() was done. This lead to multiple threads doing migration. When multiple threads try to move the same file there can be deadlocks.) posted (#5) for review on master by Niels de Vos (ndevos)

Comment 5 Anand Avati 2015-05-30 15:59:50 UTC

REVIEW: http://review.gluster.org/10977 (cluster/dht: maintain start state of rebalance daemon across graph switch.) posted (#6) for review on master by Dan Lambright (dlambrig)

Comment 6 Anand Avati 2015-06-01 18:12:41 UTC

COMMIT: http://review.gluster.org/10977 committed in master by Vijay Bellur (vbellur) 
------
commit 3f11b8e8ec6d78ebe33636b64130d5d133729f2c
Author: Dan Lambright <dlambrig>
Date:   Thu May 28 14:00:37 2015 -0400

    cluster/dht: maintain start state of rebalance daemon across graph switch.
    
    When we did a graph switch on a rebalance daemon, a second call
    to gf_degrag_start() was done. This lead to multiple threads
    doing migration. When multiple threads try to move the same
    file there can be deadlocks.
    
    Change-Id: I931ca7fe600022f245e3dccaabb1ad004f732c56
    BUG: 1226005
    Signed-off-by: Dan Lambright <dlambrig>
    Reviewed-on: http://review.gluster.org/10977
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 7 Anand Avati 2015-06-26 23:22:05 UTC

REVIEW: http://review.gluster.org/11372 (cluster/tier: stop tier migration after graph switch) posted (#10) for review on master by Dan Lambright (dlambrig)

Comment 8 Anand Avati 2015-06-26 23:36:02 UTC

REVIEW: http://review.gluster.org/11372 (cluster/tier: stop tier migration after graph switch) posted (#11) for review on master by Dan Lambright (dlambrig)

Comment 9 Anand Avati 2015-06-27 00:11:22 UTC

COMMIT: http://review.gluster.org/11372 committed in master by Dan Lambright (dlambrig) 
------
commit 875aa01ec80e56d85d0bc6028c6f1417f6ab140f
Author: Dan Lambright <dlambrig>
Date:   Tue Jun 23 16:35:03 2015 -0400

    cluster/tier: stop tier migration after graph switch
    
    On a graph switch, a new xlator and private structures are
    created. The tier migration daemon must stop using the
    old xlator and private structures and begin using the
    new ones. Otherwise, when RPCs arrive (such as counter
    queries from glusterd), the new xlator will be consulted
    but it will not have up to date information. The fix
    detects a graph switch and exits the daemon in this
    case. Typical graph switches for the tier case would
    be turning off performance translators.
    
    Change-Id: Ibfbd4720dc82ea179b77c81b8f534abced21e3c8
    BUG: 1226005
    Signed-off-by: Dan Lambright <dlambrig>
    Reviewed-on: http://review.gluster.org/11372

Comment 10 Nagaprasad Sathyanarayana 2015-10-25 15:05:35 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 11 Niels de Vos 2016-06-16 13:06:19 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user