Bug 1226153

Summary:	Quota: Do not allow set/unset of quota limit in heterogeneous cluster
Product:	[Community] GlusterFS	Reporter:	Vijaikumar Mallikarjuna <vmallika>
Component:	quota	Assignee:	Vijaikumar Mallikarjuna <vmallika>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.0	CC:	bugs, gluster-bugs, smohan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1223739	Environment:
Last Closed:	2015-06-02 08:04:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1186580, 1219955

Description Vijaikumar Mallikarjuna 2015-05-29 05:56:59 UTC

+++ This bug was initially created as a clone of Bug #1223739 +++

There is change in quota.conf format in release-3.7. In a heterogeneous cluster if the quota limit is changed, this can cause a hand-shake problem when glusterd is restarted.

Do not allow setting/removing quota limit in heterogeneous cluster

--- Additional comment from Anand Avati on 2015-05-22 04:44:31 EDT ---

REVIEW: http://review.gluster.org/10889 (quota: quota.conf backward compatibility fix) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Anand Avati on 2015-05-28 02:55:31 EDT ---

REVIEW: http://review.gluster.org/10889 (quota: quota.conf backward compatibility fix) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)

--- Additional comment from Anand Avati on 2015-05-28 21:57:46 EDT ---

COMMIT: http://review.gluster.org/10889 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit b7f05e64f615a12e6487eab64544b8f92a6037ae
Author: vmallika <vmallika>
Date:   Fri May 22 14:04:31 2015 +0530

    quota: quota.conf backward compatibility fix
    
    In release-3.7 the format of quota.conf is changed.
    There is a backward compatibility issues during upgrade
    1) There can be an issue when peer sync between node-3.6 and node-3.7
    2) If the user sets/removes limit, there is will different format of
       file in node-3.6 and node-3.7
    
    This patch fixes the issue:
    1) restrict the user to execute command quota enable, limit-usage, remove
    2) write quota.conf in older format if op-version is less than 3.6
    
    Change-Id: Ib76f5a0a85394642159607a105cacda743e7d26b
    BUG: 1223739
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/10889
    Tested-by: NetBSD Build System
    Reviewed-by: Krishnan Parthasarathi <kparthas>

Comment 1 Anand Avati 2015-06-01 09:13:41 UTC

COMMIT: http://review.gluster.org/10985 committed in release-3.7 by Krishnan Parthasarathi (kparthas) 
------
commit 4c630a77e1325349adb369f9a7c83557007eda56
Author: vmallika <vmallika>
Date:   Fri May 22 14:04:31 2015 +0530

    quota: quota.conf backward compatibility fix
    
    This is a backport of http://review.gluster.org/#/c/10889/
    
    > In release-3.7 the format of quota.conf is changed.
    > There is a backward compatibility issues during upgrade
    > 1) There can be an issue when peer sync between node-3.6 and node-3.7
    > 2) If the user sets/removes limit, there is will different format of
    >    file in node-3.6 and node-3.7
    >
    > This patch fixes the issue:
    > 1) restrict the user to execute command quota enable, limit-usage, remove
    > 2) write quota.conf in older format if op-version is less than 3.6
    >
    > Change-Id: Ib76f5a0a85394642159607a105cacda743e7d26b
    > BUG: 1223739
    > Signed-off-by: vmallika <vmallika>
    > Reviewed-on: http://review.gluster.org/10889
    > Tested-by: NetBSD Build System
    > Reviewed-by: Krishnan Parthasarathi <kparthas>
    
    Change-Id: I3d5075b96de1e125d30b0f6045389573aaaaecdb
    BUG: 1226153
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/10985
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 2 Niels de Vos 2015-06-02 08:04:17 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.1, please reopen this bug report.

glusterfs-3.7.1 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.packaging/1
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user