Bug 1226213

Summary: snap_scheduler script must be usable as python module.
Product: [Community] GlusterFS Reporter: Darshan <dnarayan>
Component: snapshotAssignee: Darshan <dnarayan>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 3.7.0CC: avishwan, bugs, gluster-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: Scheduler
Fixed In Version: glusterfs-3.7.2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1220670 Environment:
Last Closed: 2015-06-20 09:49:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1220670, 1231078    
Bug Blocks:    

Description Darshan 2015-05-29 08:37:01 UTC
+++ This bug was initially created as a clone of Bug #1220670 +++

Description of problem:
snap_scheduler script must be usable as python module. It would be better for other python programs to use snap_scheduler as a module, than executing it. 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-05-12 08:58:24 EDT ---

REVIEW: http://review.gluster.org/10760 (snapshot/scheduler: Modified main() function to take arguments.) posted (#1) for review on master by darshan n (dnarayan)

--- Additional comment from Anand Avati on 2015-05-19 02:58:10 EDT ---

REVIEW: http://review.gluster.org/10760 (snapshot/scheduler: Modified main() function to take arguments.) posted (#2) for review on master by darshan n (dnarayan)

--- Additional comment from Anand Avati on 2015-05-20 01:46:04 EDT ---

REVIEW: http://review.gluster.org/10760 (snapshot/scheduler: Modified main() function to take arguments.) posted (#3) for review on master by darshan n (dnarayan)

--- Additional comment from Anand Avati on 2015-05-29 04:20:02 EDT ---

REVIEW: http://review.gluster.org/10760 (snapshot/scheduler: Modified main() function to take arguments.) posted (#5) for review on master by darshan n (dnarayan)

Comment 1 Anand Avati 2015-05-29 08:38:54 UTC
REVIEW: http://review.gluster.org/10997 (snapshot/scheduler: Modified main() function to take arguments.) posted (#1) for review on release-3.7 by darshan n (dnarayan)

Comment 2 Anand Avati 2015-06-14 04:57:33 UTC
COMMIT: http://review.gluster.org/10997 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit 5a37c82036a381927bfea3784fbb7e762a4b5e3c
Author: nnDarshan <dnarayan>
Date:   Tue May 12 17:57:46 2015 +0530

    snapshot/scheduler: Modified main() function to take arguments.
    
    Modified the main function to take script arguments, so that this
    script can be used as a module by other programs .
    
    Change-Id: I902f0bc7ddfbf0d335cc087f51b1a7af4b7157fc
    BUG: 1226213
    Signed-off-by: nnDarshan <dnarayan>
    Reviewed On: http://review.gluster.org/#/c/10760/
    Reviewed-on: http://review.gluster.org/10997
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Aravinda VK <avishwan>
    Tested-by: NetBSD Build System <jenkins.org>

Comment 3 Niels de Vos 2015-06-20 09:49:07 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.2, please reopen this bug report.

glusterfs-3.7.2 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/packaging/2015-June/000006.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user