Bug 1226272

Summary:	Volume heal info not reporting files in split brain and core dumping, after upgrading to 3.7.0
Product:	[Community] GlusterFS	Reporter:	Poornima G <pgurusid>
Component:	core	Assignee:	Pranith Kumar K <pkarampu>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.0	CC:	bugs, gluster-bugs
Target Milestone:	---	Keywords:	Patch, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1226276 (view as bug list)		Environment:
Last Closed:	2015-06-20 09:49:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1226276
Bug Blocks:

Description Poornima G 2015-05-29 10:58:08 UTC

Description of problem:

Volume heal info core dumps when there is qemu-block.


Version-Release number of selected component (if applicable):
gluster-3.7.0

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:
Core dump with below trace:
Program terminated with signal 11, Segmentation fault.
#0  inode_unref (inode=0x7f7a1e27806c) at inode.c:499
499             table = inode->table;
(gdb) bt
#0  inode_unref (inode=0x7f7a1e27806c) at inode.c:499
#1  0x00007f7a265e8a61 in fini (this=<optimized out>) at qemu-block.c:1092
#2  0x00007f7a39a53791 in xlator_fini_rec (xl=0x7f7a2000b9a0) at xlator.c:463
#3  0x00007f7a39a53725 in xlator_fini_rec (xl=0x7f7a2000d450) at xlator.c:453
#4  0x00007f7a39a53725 in xlator_fini_rec (xl=0x7f7a2000e800) at xlator.c:453
#5  0x00007f7a39a53725 in xlator_fini_rec (xl=0x7f7a2000fbb0) at xlator.c:453
#6  0x00007f7a39a53725 in xlator_fini_rec (xl=0x7f7a20010f80) at xlator.c:453
#7  0x00007f7a39a53725 in xlator_fini_rec (xl=0x7f7a20012330) at xlator.c:453
#8  0x00007f7a39a53725 in xlator_fini_rec (xl=0x7f7a200136e0) at xlator.c:453
#9  0x00007f7a39a53725 in xlator_fini_rec (xl=0x7f7a20014b30) at xlator.c:453
#10 0x00007f7a39a53725 in xlator_fini_rec (xl=0x7f7a20015fc0) at xlator.c:453
#11 0x00007f7a39a54eea in xlator_tree_fini (xl=<optimized out>) at xlator.c:545
#12 0x00007f7a39a90b25 in glusterfs_graph_deactivate (graph=<optimized out>) at graph.c:340
#13 0x00007f7a38d50e3c in pub_glfs_fini (fs=fs@entry=0x7f7a3a6b6010) at glfs.c:1155
#14 0x00007f7a39f18ed4 in main (argc=<optimized out>, argv=<optimized out>) at glfs-heal.c:821


Expected results:
No crash

Additional info:

Comment 1 Niels de Vos 2015-06-02 12:41:20 UTC

Needs a backport of the patch for Bug 1226276.

Comment 2 Anand Avati 2015-06-02 14:11:53 UTC

REVIEW: http://review.gluster.org/11047 (features/qemu-block: Don't unref root inode) posted (#1) for review on release-3.7 by Pranith Kumar Karampuri (pkarampu)

Comment 3 Anand Avati 2015-06-02 14:12:16 UTC

REVIEW: http://review.gluster.org/11048 (heal: Do not call glfs_fini in final builds) posted (#1) for review on release-3.7 by Pranith Kumar Karampuri (pkarampu)

Comment 4 Anand Avati 2015-06-04 03:00:02 UTC

REVIEW: http://review.gluster.org/11047 (features/qemu-block: Don't unref root inode) posted (#2) for review on release-3.7 by Pranith Kumar Karampuri (pkarampu)

Comment 5 Anand Avati 2015-06-12 08:58:02 UTC

COMMIT: http://review.gluster.org/11047 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit c6715cfb480583aab954ed2a0ddb8de0d1326346
Author: Pranith Kumar K <pkarampu>
Date:   Fri May 29 16:28:10 2015 +0530

    features/qemu-block: Don't unref root inode
    
            Backport of http://review.gluster.org/11002
                        http://review.gluster.org/11076
    
    Root inode doesn't participate in ref/unref. Don't do it
    in fini as by the time fini is called itable would be destroyed.
    
    BUG: 1226272
    Change-Id: I776d8e9359c8b51763d9d2588a80311434a0ede3
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/11047
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Poornima G <pgurusid>

Comment 6 Niels de Vos 2015-06-20 09:49:11 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.2, please reopen this bug report.

glusterfs-3.7.2 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/packaging/2015-June/000006.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user