Bug 1226413

Customer logging this ticket has made code change suggestions:

this should be a new overloaded method:

public ProcessExecutionResults executeCliScript(File scriptFile, Boolean localAuth)

The existing executeCliScript(File scriptFile) method will need to remain untouched to avoid breaking existing functionality. 

I think the code change required would look a little something like this:


https://github.com/rhq-project/rhq/blob/c31f2fba8204ee73fe2065f7ef2193f87f56e14b/modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/ServerControl.java

Line 249:

		public ProcessExecutionResults executeCliScript(File scriptFile, Boolean localAuth) {
            File homeDir = serverPluginConfig.getHomeDir();
            File script = scriptFile;
            if (!script.isAbsolute()) {
                script = new File(homeDir, scriptFile.getPath());
            }
            File executable = new File("bin", serverMode.getCliScriptFileName());
            String connect = disconnected ? null : "--connect";
            String file = "--file=" + script.getAbsolutePath();
            String user = disconnected ? null : "--user=" + serverPluginConfig.getUser();
            String password = disconnected ? null : "--password=" + serverPluginConfig.getPassword();
            String controller = disconnected ? null : "--controller=" + serverPluginConfig.getNativeHost() + ":"
                + serverPluginConfig.getNativePort();

            if (systemInfo.getOperatingSystemType() != OperatingSystemType.WINDOWS) {
                if (localAuth == true) {
					return execute(null, executable, connect, file, controller);
				}
				else {
					return execute(null, executable, connect, file, user, password, controller);
				}
            }
			WinCliHelper cliHelper = new WinCliHelper();
			if (localAuth == true) {
				cliHelper = new WinCliHelper(executable, connect, file, controller);
			}
			else {
				cliHelper = new WinCliHelper(executable, connect, file, user, password, controller);
			}
            return cliHelper.execute();
        }
		

		
https://github.com/rhq-project/rhq/blob/289920aeb8d88c8a2a7f57f9a5327e3e2f19df39/modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/BaseServerComponent.java

Line 766:

 protected BundleHandoverResponse handleExecuteScript(BundleHandoverRequest handoverRequest) throws IOException {
        Map<String, String> params = handoverRequest.getParams();

        long waitTime;
        String waitTimeParam = params.get("waitTime");
        if (waitTimeParam != null) {
            try {
                waitTime = Long.parseLong(waitTimeParam);
                if (waitTime <= 0) {
                    return BundleHandoverResponse.failure(INVALID_PARAMETER, "waitTime must greater than 0");
                }
            } catch (NumberFormatException e) {
                return BundleHandoverResponse.failure(INVALID_PARAMETER, "waitTime is not a number");
            }
        } else {
            waitTime = HOURS.toMillis(1);
        }

		boolean localAuth = new Boolean(false);
        String localAuthParam = params.get("localAuth");
        if (localAuthParam != null) {
            try {
				localAuth = Boolean.parseBoolean(localAuthParam);
			}
			catch(BooleanFormatException e) {
				return BundleHandoverResponse.failure(INVALID_PARAMETER, "localAuth value could not be parsed");
			}
		}
		
        boolean killOnTimeout = Boolean.parseBoolean(params.get("killOnTimeout"));

        File scriptFile = null;
        try {
            scriptFile = File.createTempFile(handoverRequest.getFilename(), ".tmp", context.getTemporaryDirectory());
            FileUtil.writeFile(handoverRequest.getContent(), scriptFile);

            ProcessExecutionResults results = ServerControl //
                .onServer( //
                        getServerPluginConfiguration().getPluginConfig(), //
                        getMode(), //
                    context.getSystemInformation() //
                ) //
                .waitingFor(waitTime) //
                .killingOnTimeout(killOnTimeout) //
                .cli() //
                .executeCliScript(scriptFile.getAbsoluteFile(), localAuth);

            logExecutionResults(results);

            Throwable error = results.getError();
            if (error != null) {
                return BundleHandoverResponse.failure(EXECUTION, error.getMessage(), error);
            }
            Integer exitCode = results.getExitCode();
            if (exitCode == null) {
                return BundleHandoverResponse.failure(EXECUTION, "Timeout waiting for completion of the CLI process");
            }
            if (exitCode != 0) {
                return BundleHandoverResponse.failure(EXECUTION, "CLI process exit code is " + exitCode);
            }
            return BundleHandoverResponse.success();

        } finally {
            if (scriptFile != null) {
                scriptFile.delete();
            }
        }
    }

I think issue has been addressed within Bug 1227459. I also think, that bundle should not provide authorization method to be used by plugin. 

My suggestion is to close this bug as duplicate of Bug 1227459

in master

https://github.com/rhq-project/rhq/commit/f763d7f440ffc9d270ceb1dc5bbed627525014a0

Error from comment 7 is caused by EAP bz1238263

Verified that rhq:handover does not hang and error message contains "Unable to connect due to unrecognised server certificate. Server's certificate needs to be manually accepted by user." and no jboss cli processes are running.

Also verified that handover works once the certificate is permanently accepted.

On linux for EAP 6.2, 6.3, 6.4
On win for EAP 6.4

There is one limitation - see https://bugzilla.redhat.com/show_bug.cgi?id=1227459#c14