Bug 1226443

Summary: [rfe] ignore unknown fields in testinfo.desc
Product: [Retired] Beaker Reporter: Bill Peck <bpeck>
Component: generalAssignee: Dan Callaghan <dcallagh>
Status: CLOSED CURRENTRELEASE QA Contact: tools-bugs <tools-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 20CC: aigao, dcallagh, dowang, ebaak, haliu, pkremens
Target Milestone: 21.0Keywords: NeedsTestCase, Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-08-26 06:18:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Bill Peck 2015-05-29 19:24:29 UTC
Description of problem:
Beaker should ignore unknown fields when importing task rpms

Version-Release number of selected component (if applicable):
20

How reproducible:
everytime


I didn't think beaker enforced this because I was looking at an old version of the code when I discussed this with Dan.

Comment 1 Bill Peck 2015-06-12 01:34:39 UTC
 http://gerrit.beaker-project.org/4247

Comment 2 Dan Callaghan 2015-06-12 02:17:34 UTC
Some background info: some Beaker tasks may be used both inside of Beaker through the normal task library with beah, and also outside of Beaker using restraint. Currently, if any restraint-specific fields are added to testinfo.desc Beaker will refuse to accept the task upload because unrecognised fields in testinfo.desc are treated as a "warning" by the parser.

A workaround is to keep restraint-specific options in the metadata file, rather than testinfo.desc.

(Need to figure out exactly what restraint-specific fields people are putting into testinfo.desc, and what the equivalents would be in metadata.)

Comment 3 Dan Callaghan 2015-06-16 03:43:14 UTC
*** Bug 1231715 has been marked as a duplicate of this bug. ***

Comment 4 Dan Callaghan 2015-06-16 03:43:48 UTC
Assuming the problematic field is RepoRequires, a workaround is to remove RepoRequires from testinfo.desc, and instead create a restraint-formatted metadata file in the task.

http://restraint.readthedocs.org/en/latest/tasks.html#metadata

It doesn't seem to be documented currently, but there is a repoRequires= option under [restraint], for example:

https://git.beaker-project.org/cgit/restraint/tree/src/test-data/parse_metadata/dependencies/metadata

Comment 8 Dan Callaghan 2015-08-26 06:18:02 UTC
Beaker 21.0 has been released.