Bug 1226990

Summary:	[rhel-7.1.3] docker: docker-storage-setup exits if growpart is not installed
Product:	Red Hat Enterprise Linux 7	Reporter:	Vivek Goyal <vgoyal>
Component:	docker	Assignee:	Lokesh Mandvekar <lsm5>
Status:	CLOSED ERRATA	QA Contact:	Luwen Su <lsu>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	7.1	CC:	dwalsh, lsm5, miabbott, sghosh, walters
Target Milestone:	rc	Keywords:	Extras
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-06-23 09:30:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vivek Goyal 2015-06-01 15:22:35 UTC

Description of problem:

On rhel, growpart is not available. Right now docker-storage-setup is written
in such a way that it checks for presence of growpart and if does not exist it
continues.

But current code exits as soon as it sees growpart is not available.

[ -x "/usr/bin/growpart" ] || return

I think it is because of presence of "set -e" option in the script and it
is treated as error.

We need to return 0 so that script continues.

[ -x "/usr/bin/growpart" ] || return 0

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Daniel Walsh 2015-06-02 17:56:24 UTC

Vivek have you got an updated version?

Comment 3 Vivek Goyal 2015-06-02 18:04:25 UTC

Dan, this got fixed upstream as well as fix is available in docker-1.6.2-5.el7

Comment 5 Luwen Su 2015-06-15 09:25:05 UTC

In docker-1.6.2-10.el7.x86_64,
without the fix, it will looks like
# docker-storage-setup 
  Volume group "sda3" not found
  Cannot process volume group sda3

after the patch, the script can continue
# docker-storage-setup 
  Volume group "sda3" not found
  Cannot process volume group sda3
  Metadata volume docker-poolmeta already exists. Not creating a new one.

Move to verified.

Comment 7 errata-xmlrpc 2015-06-23 09:30:11 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1167.html