Bug 1227021

Summary: [abrt] exo: exo-compose-mail-1:98:<module>:TypeError: cannot concatenate 'str' and 'list' objects
Product: [Fedora] Fedora Reporter: Roel van de Kraats <rhbug>
Component: exoAssignee: Kevin Fenzi <kevin>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 22CC: kevin, nonamedotc
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
URL: https://retrace.fedoraproject.org/faf/reports/bthash/51cac13f387cef9a730b39b63b587115118b6541
Whiteboard: abrt_hash:b74290055f5a7a88ec5ceba3195af826c9221a2f
Fixed In Version: exo-0.10.6-3.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-07-13 19:15:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
File: backtrace
none
File: environ none

Description Roel van de Kraats 2015-06-01 17:54:41 UTC
Description of problem:
Clicked File -> Email Link in Firefox

Version-Release number of selected component:
exo-0.10.4-1.fc22

Additional info:
reporter:       libreport-2.5.1
cmdline:        /usr/bin/python -tt /usr/lib64/xfce4/exo-1/exo-compose-mail-1 mozilla-remote /usr/bin/thunderbird mailto:?body=http%3A%2F%2Ftweakers.net%2Fnieuws%2F103415%2Fkpn-verhoogt-databundels-zakelijke-abonnementen.html&subject=KPN%20verhoogt%20databundels%20zakelijke%20abonnementen%20-%20Tablets%20en%20telefoons%20-%20Nieuws%20-%20Tweakers
executable:     /usr/lib64/xfce4/exo-1/exo-compose-mail-1
kernel:         4.0.4-303.fc22.x86_64
runlevel:       N 5
type:           Python
uid:            578

Truncated backtrace:
exo-compose-mail-1:98:<module>:TypeError: cannot concatenate 'str' and 'list' objects

Traceback (most recent call last):
  File "/usr/lib64/xfce4/exo-1/exo-compose-mail-1", line 98, in <module>
    command += ",subject='" + subject + "'"
TypeError: cannot concatenate 'str' and 'list' objects

Local variables in innermost frame:
parse_url: <function parse_url at 0x7efdff5f9140>
attachments: []
cc: []
subject: ['KPN verhoogt databundels zakelijke abonnementen - Tablets en telefoons - Nieuws - Tweakers']
mailto: {'body': ['http://tweakers.net/nieuws/103415/kpn-verhoogt-databundels-zakelijke-abonnementen.html'], 'to': [], 'subject': ['KPN verhoogt databundels zakelijke abonnementen - Tablets en telefoons - Nieuws - Tweakers']}
binary: '/usr/bin/thunderbird'
style: 'mozilla-remote'
urllib: <module 'urllib' from '/usr/lib64/python2.7/urllib.pyc'>
__package__: None
to: []
raw_mailto: 'mailto:?body=http%3A%2F%2Ftweakers.net%2Fnieuws%2F103415%2Fkpn-verhoogt-databundels-zakelijke-abonnementen.html&subject=KPN%20verhoogt%20databundels%20zakelijke%20abonnementen%20-%20Tablets%20en%20telefoons%20-%20Nieuws%20-%20Tweakers'
command: "xfeDoCommand(composeMessage,to='',cc='',bcc='',attachment=''"
__doc__: None
body: 'http://tweakers.net/nieuws/103415/kpn-verhoogt-databundels-zakelijke-abonnementen.html'
__builtins__: <module '__builtin__' (built-in)>
__file__: '/usr/lib64/xfce4/exo-1/exo-compose-mail-1'
args: []
sys: <module 'sys' (built-in)>
__name__: '__main__'
bcc: []
urlparse: <module 'urlparse' from '/usr/lib64/python2.7/urlparse.pyc'>
posix: <module 'posix' (built-in)>
os: <module 'os' from '/usr/lib64/python2.7/os.pyc'>

Potential duplicate: bug 983150

Comment 1 Roel van de Kraats 2015-06-01 17:54:44 UTC
Created attachment 1033448 [details]
File: backtrace

Comment 2 Roel van de Kraats 2015-06-01 17:54:45 UTC
Created attachment 1033449 [details]
File: environ

Comment 3 Kevin Fenzi 2015-06-24 20:20:38 UTC
Sorry for the long delay here. ;( 

Can you try this scratch build: 

https://koji.fedoraproject.org/koji/taskinfo?taskID=10200352

and if it fails, please provide the full backtrace?
Thanks.

Comment 4 Roel van de Kraats 2015-06-25 08:12:19 UTC
Hi Kevin,

Thanks for the update! The new version fixes the exception.

But... it doesn't properly call Thunderbird. And neither does the previous 0.10.6-1.fc22

The problem is that args[0] in 'posix.execv(binary,args)' should contain the name of the program. Now args[0] contains '-remote', which causes this argument to get lost.

You can fix this by initializing args with 'args = [binary]' instead of with an empty list. At least that works for me :-)

Comment 5 Kevin Fenzi 2015-06-25 16:50:46 UTC
ah indeed. ;) 

Can you try:

https://koji.fedoraproject.org/koji/taskinfo?taskID=10212820

and see if it works out of the box for you?

Comment 6 Roel van de Kraats 2015-06-25 18:35:16 UTC
Works fine Kevin!

Comment 7 Kevin Fenzi 2015-06-25 18:56:35 UTC
Great. Will push out this fix then. ;)

Comment 8 Fedora Update System 2015-06-25 19:18:07 UTC
exo-0.10.6-3.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/exo-0.10.6-3.fc22

Comment 9 Fedora Update System 2015-06-26 06:41:07 UTC
Package exo-0.10.6-3.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing exo-0.10.6-3.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-10761/exo-0.10.6-3.fc22
then log in and leave karma (feedback).

Comment 10 Fedora Update System 2015-07-13 19:15:25 UTC
exo-0.10.6-3.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.