Bug 1227618

Summary: [geo-rep]: use_meta_volume config option should be validated for its values
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Rahul Hinduja <rhinduja>
Component: geo-replicationAssignee: Aravinda VK <avishwan>
Status: CLOSED ERRATA QA Contact: storage-qa-internal <storage-qa-internal>
Severity: medium Docs Contact:
Priority: medium    
Version: rhgs-3.1CC: aavati, asrivast, avishwan, csaba, khiremat, nlevinki, nsathyan
Target Milestone: ---   
Target Release: RHGS 3.1.0   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.7.1-3 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1230090 (view as bug list) Environment:
Last Closed: 2015-07-29 04:55:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1202842, 1223636, 1230090, 1230691    

Description Rahul Hinduja 2015-06-03 07:04:15 UTC
Description of problem:
=======================

use_meta_volume config option should be True/False, On/Off, 0/1, enable/disable. But currently it accepts all the values for example:


[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume xyz
geo-replication config updated successfully
[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume
xyz
[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume 0123
geo-replication config updated successfully
[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume
0123
[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config \!use_meta_volume 
geo-replication config updated successfully
[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume
[root@georep1 scripts]# 


Version-Release number of selected component (if applicable):
==============================================================

glusterfs-3.7.0-3.el6rhs.x86_64

How reproducible:
=================

Always


Steps to Reproduce:
===================
1. gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume xyz

Actual results:
===============

[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume xyz
geo-replication config updated successfully
[root@georep1 scripts]#

Expected results:
=================


[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume xyz
Invalid value(xyz) for option use_meta_volume
geo-replication command failed
[root@georep1 scripts]#

Comment 5 Rahul Hinduja 2015-06-18 08:28:22 UTC
Verified with build: glusterfs-3.7.1-3.el6rhs.x86_64

Command fails for invalid input. Marking the bug to verified 


[root@georep1 ~]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume
true
[root@georep1 ~]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume xyz
Invalid value(xyz) for option use_meta_volume
geo-replication command failed
[root@georep1 ~]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume 123
Invalid value(123) for option use_meta_volume
geo-replication command failed
[root@georep1 ~]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume -1
Invalid value(-1) for option use_meta_volume
geo-replication command failed
[root@georep1 ~]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume 0
geo-replication config updated successfully
[root@georep1 ~]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume
0
[root@georep1 ~]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume 1
geo-replication config updated successfully
[root@georep1 ~]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume
1
[root@georep1 ~]#

Comment 6 errata-xmlrpc 2015-07-29 04:55:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-1495.html