Bug 1227621

Summary: Log file saved on conversion server even "Enable server-side debugging" is not ticked
Product: Red Hat Enterprise Linux 7 Reporter: tingting zheng <tzheng>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED NOTABUG QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.2CC: juzhou, mzhan, ptoscano, tzheng, xiaodwan
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard: P2V
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-06 08:51:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description tingting zheng 2015-06-03 07:19:50 UTC
Description:
Log file saved on conversion server even "Enable server-side debugging" is not ticked.

Version:
libguestfs-1.28.1-1.37.el7.x86_64
virt-v2v-1.28.1-1.37.el7.x86_64
livecd-p2v-201505191242.iso	

How reproducible:
100%

Steps to Reproduce:
1.Boot host from virt-p2v iso.
2.After virt-p2v client is launched,fill correct conversion server ip,user name and password.
3.After connected to the conversion server,make sure "Enable server-side debugging" is not ticked.
4.When the conversion starts,there is message shows on virt-p2v client:"Log files and ebug information is saved to this directory on the conversion server:/tmp/virt-p2v-****".
5.On conversion server,check under /tmp,there is new log file created.

Actual results:
As description.

Expected results:
If untick "Enable server-side debugging",no log created on conversion server.

Additional info:

Comment 2 Richard W.M. Jones 2015-09-03 15:37:07 UTC
I suspect there is a bit of confusion here, and this is NOTABUG.

When you tick the box, it enables full debugging information
(ie. 'virt-v2v -v -x').

If the box is NOT ticked, the log is still written, but it won't
contain any debug information.

In any case, I cannot reproduce this bug (upstream, but the relevant
code hasn't changed for a year).  With the box not ticked, I get a
log file:

$ ls -l
total 20
-rw-r--r--. 1 root root    5 Sep  3 16:34 name
-rw-r--r--. 1 root root 1122 Sep  3 16:34 physical.xml
-rw-r--r--. 1 root root    2 Sep  3 16:35 status
-rw-r--r--. 1 root root   29 Sep  3 16:34 time
-rw-r--r--. 1 root root  458 Sep  3 16:35 virt-v2v-conversion-log.txt

but the log file contains only the basic information and no
debugging, which is the expected behaviour.

$ cat virt-v2v-conversion-log.txt
[   0.0] Opening the source -i libvirtxml /tmp/virt-p2v-20150903-laoznquu/physical.xml
[   0.0] Creating an overlay to protect the source from being modified
[   0.5] Opening the overlay
[  74.7] Initializing the target -o local -os /var/tmp
[  74.7] Inspecting the overlay
virt-v2v: error: no root device found in this operating system image.
[...]

Comment 3 tingting zheng 2015-09-06 08:09:19 UTC
(In reply to Richard W.M. Jones from comment #2)
> I suspect there is a bit of confusion here, and this is NOTABUG.
> 
> When you tick the box, it enables full debugging information
> (ie. 'virt-v2v -v -x').
> 
> If the box is NOT ticked, the log is still written, but it won't
> contain any debug information.
> 
> In any case, I cannot reproduce this bug (upstream, but the relevant
> code hasn't changed for a year).  With the box not ticked, I get a
> log file:
> 
> $ ls -l
> total 20
> -rw-r--r--. 1 root root    5 Sep  3 16:34 name
> -rw-r--r--. 1 root root 1122 Sep  3 16:34 physical.xml
> -rw-r--r--. 1 root root    2 Sep  3 16:35 status
> -rw-r--r--. 1 root root   29 Sep  3 16:34 time
> -rw-r--r--. 1 root root  458 Sep  3 16:35 virt-v2v-conversion-log.txt
> 
> but the log file contains only the basic information and no
> debugging, which is the expected behaviour.
> 
> $ cat virt-v2v-conversion-log.txt
> [   0.0] Opening the source -i libvirtxml
> /tmp/virt-p2v-20150903-laoznquu/physical.xml
> [   0.0] Creating an overlay to protect the source from being modified
> [   0.5] Opening the overlay
> [  74.7] Initializing the target -o local -os /var/tmp
> [  74.7] Inspecting the overlay
> virt-v2v: error: no root device found in this operating system image.
> [...]

I just misunderstood that if tick the box,no log will be wrriten to p2v server.
Pls close it as "NOTABUG".

Comment 4 Richard W.M. Jones 2015-09-06 08:51:15 UTC
Thanks Tingting - closing per comment 2 & comment 3.