Bug 1228089

Summary: Review Request: php-zetacomponents-base - Zeta Base Component
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: Package ReviewAssignee: Shawn Iwinski <shawn>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, shawn
Target Milestone: ---Flags: shawn: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: php-zetacomponents-base-1.9-2.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-06-29 16:57:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 1228087    
Bug Blocks: 1228090, 1228091    
Description Flags
fedora-review.txt none

Description Remi Collet 2015-06-04 07:53:22 UTC
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/9ea96b23650357863b616241909cdeabc5f50a12/php/zeta/php-zetacomponents-base/php-zetacomponents-base.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-zetacomponents-base-1.9-2.remi.src.rpm
This is the base package of the Zeta components, offering the basic
support that all Components need. In the first version this will be the
autoload support.

Fedora Account System Username: remi

Comment 1 Shawn Iwinski 2015-06-28 20:46:30 UTC
Created attachment 1044101 [details]

Full (i.e. BuildRequires) phpcompatinfo

phpCompatInfo version 4.2.0 DB built May 22 2015 19:29:18 CEST

Comment 2 Shawn Iwinski 2015-06-28 20:47:18 UTC
Created attachment 1044102 [details]

Source (i.e. Requires) phpcompatinfo

phpCompatInfo version 4.2.0 DB built May 22 2015 19:29:18 CEST

Comment 3 Shawn Iwinski 2015-06-28 20:47:57 UTC
Created attachment 1044103 [details]

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1228089
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby

Comment 4 Shawn Iwinski 2015-06-28 20:51:29 UTC
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import.

[x]: Requires correct, justified where necessary.

     Per phpcompatinfo:
         BuildRequires: php-pcre
         BuildRequires: php-simplexml
         BuildRequires: php-spl
     Why the following?:
         BuildRequires: php-posix
         Requires:      php-posix

I'll leave those details up to you :)

No blockers.

===== APPROVED =====

Comment 5 Remi Collet 2015-06-29 05:12:46 UTC
>      Why the following?:
>          BuildRequires: php-posix
>          Requires:      php-posix

From phpcompatinfo report optional dep.

Conditions Analysis
    function_exists(posix_getpwuid) 1       posix    4.0.0       4.0.0        

(yes having optional dep "outside" the "Extension Analysis" seems ugly).

Comment 6 Remi Collet 2015-06-29 05:14:13 UTC
Thanks for the review!

New Package SCM Request
Package Name: php-zetacomponents-base
Short Description: Zeta Base Component
Upstream URL: http://zetacomponents.org/
Owners: remi
Branches: f21 f22 el6 epel7

Comment 7 Gwyn Ciesla 2015-06-29 15:59:54 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2015-06-29 17:08:01 UTC
php-zetacomponents-base-1.9-2.el6 has been submitted as an update for Fedora EPEL 6.

Comment 9 Fedora Update System 2015-06-29 17:09:13 UTC
php-zetacomponents-base-1.9-2.el7 has been submitted as an update for Fedora EPEL 7.

Comment 10 Fedora Update System 2015-06-29 17:09:19 UTC
php-zetacomponents-base-1.9-2.fc21 has been submitted as an update for Fedora 21.

Comment 11 Fedora Update System 2015-06-29 17:09:28 UTC
php-zetacomponents-base-1.9-2.fc22 has been submitted as an update for Fedora 22.

Comment 12 Fedora Update System 2015-07-13 19:06:10 UTC
php-zetacomponents-base-1.9-2.fc21 has been pushed to the Fedora 21 stable repository.

Comment 13 Fedora Update System 2015-07-13 19:13:08 UTC
php-zetacomponents-base-1.9-2.fc22 has been pushed to the Fedora 22 stable repository.

Comment 14 Fedora Update System 2015-07-16 01:46:57 UTC
php-zetacomponents-base-1.9-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 15 Fedora Update System 2015-07-16 01:47:57 UTC
php-zetacomponents-base-1.9-2.el7 has been pushed to the Fedora EPEL 7 stable repository.