Bug 1228132

Summary: Parameter 'Cinder-Storage-1::Flavor' is invalid: Error validating value u'': The Flavor ID () could not be found.
Product: Red Hat OpenStack Reporter: Jiri Tomasek <jtomasek>
Component: python-rdomanager-oscpluginAssignee: Lennart Regebro <lregebro>
Status: CLOSED DUPLICATE QA Contact: Ola Pavlenko <opavlenk>
Severity: unspecified Docs Contact:
Priority: medium    
Version: DirectorCC: akrivoka, calfonso, dnavale, jslagle, lregebro, mburns, rhel-osp-director-maint, rrosa
Target Milestone: z1Keywords: Triaged
Target Release: Director   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-07-24 06:25:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1240260    
Bug Blocks:    

Description Jiri Tomasek 2015-06-04 09:38:30 UTC
Description of problem:
Any Role that is added to Plan, but is not added to any Flavor (should not be used in Deployment) but Heat probably checks
all roles that are added to the plan (workaround: add all roles to flavor and not add nodes to it)

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Add some roles to flavor on overview page set node count
2. Leave some roles unassigned to Flavor 
3. Launch the deployment

Actual results:
ERROR:tuskar_ui.infrastructure.overview.forms:ERROR: Parameter 'Cinder-Storage-1::Flavor' is invalid: Error validating value u'': The Flavor ID () could not be found.                                                                                                          
Traceback (most recent call last):                                                                                                      
  File "/home/stack/tuskar-ui/tuskar_ui/infrastructure/overview/forms.py", line 312, in handle                                          
    plan.provider_resource_templates)                                                                                                   
  File "/home/stack/tuskar-ui/tuskar_ui/api/heat.py", line 90, in create                                                                
    stack = heat.stack_create(request, **fields)                                                                                        
  File "/home/stack/horizon/openstack_dashboard/api/heat.py", line 102, in stack_create                                                 
    return heatclient(request, password).stacks.create(**kwargs)                                                                        
  File "/home/stack/horizon/.venv/lib/python2.7/site-packages/heatclient/v1/stacks.py", line 134, in create                             
    data=kwargs, headers=headers)                                                                                                       
  File "/home/stack/horizon/.venv/lib/python2.7/site-packages/heatclient/common/http.py", line 265, in json_request                     
    resp = self._http_request(url, method, **kwargs)                                                                                    
  File "/home/stack/horizon/.venv/lib/python2.7/site-packages/heatclient/common/http.py", line 220, in _http_request                    
    raise exc.from_response(resp)                                                                                                       
HTTPBadRequest: ERROR: Parameter 'Cinder-Storage-1::Flavor' is invalid: Error validating value u'': The Flavor ID () could not be found.
Recoverable error: ERROR: Parameter 'Cinder-Storage-1::Flavor' is invalid: Error validating value u'': The Flavor ID () could not be found. 

Expected results:
Deployment runs smoothly

Additional info:

Comment 3 Jiri Tomasek 2015-06-04 09:44:55 UTC
This is happening because Tuskar expects all Roles that are added to plan to be valid. When we don't assign role to flavor in the UI, the resulting template for role is invalid.

UI needs to fix this form the UX POW and ensure that user set Flavor to all Roles that are added in the Plan

Comment 6 Ana Krivokapic 2015-06-24 14:17:58 UTC
A workaround for this is to explicitly set flavors to all roles.

Comment 7 Lennart Regebro 2015-07-02 14:56:50 UTC
The CentOS repo now uses upstream for tripleo-image-elements, which should solve this.

Comment 10 Lennart Regebro 2015-07-13 07:31:20 UTC
I don't think this needs documentation.

Comment 11 Ola Pavlenko 2015-07-14 11:35:05 UTC
there is no patch/fix to be tested for this bug. 
the behavior is as designed.

Comment 12 Ana Krivokapic 2015-07-14 11:53:25 UTC
All roles need a flavor set before deployment is attempted. This is documented and is the intended behavior.

We should improve the error message, in case the user attempts deployment without setting flavors to all roles.

This is definitely not a blocker.

Comment 13 Rafael Rosa 2015-07-14 13:20:14 UTC
Agreed with Ana, it should be improved but isn't a blocker, moving it to A1.

Comment 15 Lennart Regebro 2015-07-24 06:25:28 UTC
This and 1232435 are duplicates. The later one also have an RDO clone, so I'm closing this.

*** This bug has been marked as a duplicate of bug 1232435 ***