Bug 1228146

Fyi: wg/lettuce is outdated and no longer maintained. Spring Data Redis switches from wg/lettuce to mp911de/lettuce within https://github.com/spring-projects/spring-data-redis/pull/144

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It
     is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
     when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in lettuce-
     javadoc
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: lettuce-2.3.3-1.fc21.noarch.rpm
          lettuce-javadoc-2.3.3-1.fc21.noarch.rpm
          lettuce-2.3.3-1.fc21.src.rpm
lettuce.noarch: W: spelling-error Summary(en_US) Scalable -> Salable, Callable, Calculable
lettuce.noarch: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
lettuce.noarch: W: spelling-error %description -l en_US asyncronous -> asynchronous, synchronous, noncancerous
lettuce.noarch: W: spelling-error %description -l en_US transactional -> transaction, transnational, transitional
lettuce.noarch: W: spelling-error %description -l en_US netty -> natty, nutty, petty
lettuce.src: W: spelling-error Summary(en_US) Scalable -> Salable, Callable, Calculable
lettuce.src: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
lettuce.src: W: spelling-error %description -l en_US asyncronous -> asynchronous, synchronous, noncancerous
lettuce.src: W: spelling-error %description -l en_US transactional -> transaction, transnational, transitional
lettuce.src: W: spelling-error %description -l en_US netty -> natty, nutty, petty
3 packages and 0 specfiles checked; 0 errors, 10 warnings.




Rpmlint (installed packages)
----------------------------
lettuce.noarch: W: spelling-error Summary(en_US) Scalable -> Salable, Callable, Calculable
lettuce.noarch: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
lettuce.noarch: W: spelling-error %description -l en_US asyncronous -> asynchronous, synchronous, noncancerous
lettuce.noarch: W: spelling-error %description -l en_US transactional -> transaction, transnational, transitional
lettuce.noarch: W: spelling-error %description -l en_US netty -> natty, nutty, petty
2 packages and 0 specfiles checked; 0 errors, 5 warnings.



Requires
--------
lettuce-javadoc (rpmlib, GLIBC filtered):
    jpackage-utils

lettuce (rpmlib, GLIBC filtered):
    java-headless
    jpackage-utils
    mvn(io.netty:netty:3)



Provides
--------
lettuce-javadoc:
    lettuce-javadoc

lettuce:
    lettuce
    mvn(com.lambdaworks:lettuce)
    mvn(com.lambdaworks:lettuce:pom:)



Source checksums
----------------
https://github.com/wg/lettuce/archive/2.3.3.tar.gz :
  CHECKSUM(SHA256) this package     : 7619934d48c4bd04f9c8544a3fdbcb2983af721e2d9df723980d4c09f51f223f
  CHECKSUM(SHA256) upstream package : 7619934d48c4bd04f9c8544a3fdbcb2983af721e2d9df723980d4c09f51f223f


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1228146 -P java
Buildroot used: fedora-21-x86_64
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

missed one line:
[x]: Package uses nothing in %doc for runtime.

Hello Gil!

Form my side package is o to go, unless you wont follow Mark's hint from #1.

From minor nits you may wont to improve:
lettuce.noarch: W: spelling-error %description -l en_US asyncronous -> asynchronous
I think  in this case this mostly wrong check is right :)

Also may you enable check, or write an comment to spec why it is disabled? (so why -f is needed )
I have not tried, but it whole looks so simple, that -f seems not necessary.

(In reply to jiri vanek from comment #3)
> missed one line:
> [x]: Package uses nothing in %doc for runtime.
> 
> Hello Gil!
Hi
> Form my side package is o to go, unless you wont follow Mark's hint from #1.
Thanks, for the suggestion but we haven't springframework 4.1.6.RELEASE, until we use SF 3.x series i prefer import these release.
I changed URL tag with the mp911de/lettuce home. In case if in a near future we decide to import the newer SF release
> From minor nits you may wont to improve:
> lettuce.noarch: W: spelling-error %description -l en_US asyncronous ->
> asynchronous
> I think  in this case this mostly wrong check is right :)
Fixed
> Also may you enable check, or write an comment to spec why it is disabled?
> (so why -f is needed )
> I have not tried, but it whole looks so simple, that -f seems not necessary.
Changed comment about check disabled:
Tests disabled use "web connection". Caused by: java.net.ConnectException: Connection refused: localhost/127.0.0.1:6379

Spec URL: https://gil.fedorapeople.org/lettuce.spec
SRPM URL: https://gil.fedorapeople.org/lettuce-2.3.3-1.fc20.src.rpm

New Package SCM Request
=======================
Package Name: lettuce
Short Description: Scalable Java Redis client
Upstream URL: http://redis.paluch.biz/
Owners: gil
Branches: f22
InitialCC: java-sig

Git done (by process-git-requests).

lettuce-2.3.3-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/lettuce-2.3.3-1.fc22

lettuce-2.3.3-1.fc22 has been pushed to the Fedora 22 testing repository.

lettuce-2.3.3-1.fc22 has been pushed to the Fedora 22 stable repository.