Bug 1228322

Summary: systemd kills dhclient when supervdsm is stopped
Product: [Retired] oVirt Reporter: Max Kovgan <mkovgan>
Component: vdsmAssignee: Ido Barkan <ibarkan>
Status: CLOSED CURRENTRELEASE QA Contact: Michael Burman <mburman>
Severity: high Docs Contact:
Priority: medium    
Version: 3.5CC: amarchuk, bazulay, bugs, danken, ecohen, eedri, gklein, lsurette, mburman, mgoldboi, rbalakri, sbonazzo, sshnaidm, yeylon, ylavi
Target Milestone: ---   
Target Release: 3.5.5   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: network
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
rhel7.1 [most probably any systemd based OS] Discovered on: vdsm-4.17.0.4-1.el7ev.noarch Seems to be valid for master too.
Last Closed: 2015-11-11 10:06:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
sosreport none

Description Max Kovgan 2015-06-04 15:27:43 UTC
Created attachment 1034781 [details]
sosreport

Description of problem:
hosts running affected code with DHCP configured interfaces, upon supervdsmd death will not renew the lease after its expiry
i.e. disconnect from the management network


Version-Release number of selected component (if applicable):
discovered on vdsm-4.17.0.4-1.el7ev.noarch and 4.16.x vdsm hosts,
master is affected too.

How reproducible:
It was discovered upon host reinstallation in d/s jenkins jobs that did
yum remove vdsm*,
and then install the 

Steps to Reproduce:
1.setup host with rhevm configured via dhcp [default config]
2.login into host and run:
systemctl stop supervdsm
3.wait for lease to expire

Actual results:
Upon supervdsm service stopped (or killed) dhclient is dead [killed on duty by systemd]

host disconnects after the lease expires.

Expected results:
network connectivity unaffected


Additional info:

Comment 1 Dan Kenigsberg 2015-06-05 11:23:29 UTC
Reproduction:

1. Use setupNetworks to define a network with dhcp. This creates a dhclient process that extends the lease when needed.
2. if supervdsmd is stopped (due to a bug or an upgrade or an admin decision) dhclient is killed (and the lease would not be extended).
3. even if vdsm is restarted, it does not re-create the dhclient process

Comment 2 Dan Kenigsberg 2015-06-07 09:16:31 UTC
This is awfully similar to bug 1201355, and a similart hack - of running ifup in a separate cgroup - may fix it.

Comment 3 Michael Burman 2015-09-21 07:44:40 UTC
Tested and Verified with - 

vdsm-4.17.7-1.el7ev.noarch
vdsm-4.16.27-1.el7ev.x86_64