Bug 1229340

Summary: virt-p2v no GUI mode appends \n to the final command line parameter
Product: Red Hat Enterprise Linux 7 Reporter: Richard W.M. Jones <rjones>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: high Docs Contact:
Priority: high    
Version: 7.2CC: juzhou, mzhan, ptoscano, tzheng, virt-bugs, xiaodwan
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard: P2V
Fixed In Version: libguestfs-1.28.1-1.38.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1229262 Environment:
Last Closed: 2015-11-19 07:01:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Richard W.M. Jones 2015-06-08 13:46:34 UTC 
Description of problem:

When using virt-p2v from the kernel command line, if the final
p2v.* parameter appears at the end of the command line, then
a \n character is appended to it.

For example, the following configuration won't work:

  APPEND [....] p2v.o=disk p2v.os=/var/tmp

because virt-p2v will try to use directory "/var/tmp\n" on
the conversion server.

Version-Release number of selected component (if applicable):

virt-p2v upstream in <= 1.29.46, and also in RHEL 7.1

How reproducible:

100%

Steps to Reproduce:

See my steps in https://bugzilla.redhat.com/show_bug.cgi?id=1229262#c2

Actual results:

In 'systemctl status p2v -l output' you will see:

virt-v2v: error: -os /var/tmp
: output directory does not exist or is not a directory

Notice that the error message is split across two lines, indicating
an invisible \n character appearing after /var/tmp
Comment 1 Richard W.M. Jones 2015-06-08 13:50:15 UTC 
Upstream fix:
https://github.com/libguestfs/libguestfs/commit/6114c10df05cdb1662ac22930010fd45714f9c40
Comment 2 Richard W.M. Jones 2015-06-09 14:29:08 UTC 
The fix in comment 1 wasn't quite correct.  The following commits
are needed:

https://github.com/libguestfs/libguestfs/commit/6114c10df05cdb1662ac22930010fd45714f9c40
https://github.com/libguestfs/libguestfs/commit/fc554d422a95f0cef21073a3a8ba0b2d8ddbab45
https://github.com/libguestfs/libguestfs/commit/cca4343203f18367033a56139231ff2518ad6655
https://github.com/libguestfs/libguestfs/commit/154251b3f0312864c460533ae28a09483fb70051
Comment 4 tingting zheng 2015-06-11 08:45:20 UTC 
Tested with:
livecd-p2v-201506091319.iso
virt-v2v-1.28.1-1.38.el7.x86_64
libguestfs-1.28.1-1.38.el7.x86_64

1.Add after APPEND [....] p2v.o=disk p2v.os=/var/tmp in kernel command line.

2.Launch virt-p2v client,conversion starts successfully without error info in description.

Refer to the above comments,move the bug to VERIFIED.
Comment 6 errata-xmlrpc 2015-11-19 07:01:42 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2183.html