Bug 1229592
Summary: | change-media with option update cannot eject cdrom as it always requires new source when device has source | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Yang Yang <yanyang> |
Component: | libvirt | Assignee: | Peter Krempa <pkrempa> |
Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 7.2 | CC: | dyuan, mzhan, pkrempa, pzhang, rbalakri, shyu, xuzhang |
Target Milestone: | rc | Keywords: | Regression |
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | libvirt-1.2.17-1.el7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-11-19 06:40:26 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Yang Yang
2015-06-09 08:10:40 UTC
Fixed upstream: commit 23e913671d20a9b6cc233f72cc8ac2fe996443a1 Author: Peter Krempa <pkrempa> Date: Tue Jun 9 13:27:42 2015 +0200 virsh: change-media: Fix behavior with --update without a source Docs state that it should behave like eject. Currently the code does not do that. This is a regression since f4b5f53027da4fed2250628e11bac4019. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1229592 v1.2.16-112-g23e9136 I can reproduce it . verify it like following verify version: libvirt-1.2.17-3.el7.x86_64 steps: 1>change-media via --update for a running domian 1.define and start a guest like following # virsh dumpxml r7-vm1 | grep disk -A 9 <disk type='file' device='cdrom'> <driver name='qemu' type='raw'/> <source file='/var/lib/libvirt/images/a.iso' startupPolicy='optional'/> <backingStore/> <target dev='hdc' bus='ide'/> <readonly/> <alias name='ide0-1-0'/> <address type='drive' controller='0' bus='1' target='0' unit='0'/> </disk> 2.Using change-media with --update to eject the cdrom # virsh change-media r7-vm1 hdc --update Successfully ejected media. 3.check domain xml, the media is ejected. # virsh dumpxml r7-vm1 | grep disk -A 9 <disk type='file' device='cdrom'> <driver name='qemu' type='raw'/> <source startupPolicy='optional'/> <backingStore/> <target dev='hdc' bus='ide' tray='open'/> <readonly/> <alias name='ide0-1-0'/> <address type='drive' controller='0' bus='1' target='0' unit='0'/> </disk> 2>change-media via --update with --config 1.define and start a guest like following # virsh dumpxml r7-vm1 --inactive | grep disk -A 9 <disk type='file' device='cdrom'> <driver name='qemu' type='raw'/> <source file='/var/lib/libvirt/images/b.iso' startupPolicy='optional'/> <target dev='hdc' bus='ide'/> <readonly/> <address type='drive' controller='0' bus='1' target='0' unit='0'/> </disk> # virsh change-media r7-vm1 hdc --update --config Successfully ejected media. 2. reboot guest to check # virsh destroy r7-vm1;virsh start r7-vm1 Domain r7-vm1 destroyed Domain r7-vm1 started 3.dumpxml to check, the media was ejected. # virsh dumpxml r7-vm1 | grep disk -A 9 <disk type='file' device='cdrom'> <driver name='qemu' type='raw'/> <source startupPolicy='optional'/> <backingStore/> <target dev='hdc' bus='ide'/> <readonly/> <alias name='ide0-1-0'/> <address type='drive' controller='0' bus='1' target='0' unit='0'/> </disk> 3>change-media via --update with --live --config; pass # virsh change-media r7-vm1 hdc --update --live --config Successfully ejected media. 4>change-media via --update with --current ; pass # virsh change-media r7-vm1 hdc --update --current Successfully ejected media. 5>change-media with source , the media can be changed 3. change-media via --update with a source .the media can be changed . # virsh dumpxml r7-vm1 | grep disk -A 9 <disk type='file' device='cdrom'> <driver name='qemu' type='raw'/> <source file='/var/lib/libvirt/images/b.iso' startupPolicy='optional'/> <backingStore/> <target dev='hdc' bus='ide'/> <readonly/> <alias name='ide0-1-0'/> <address type='drive' controller='0' bus='1' target='0' unit='0'/> </disk> # virsh change-media r7-vm1 hdc --update /var/lib/libvirt/images/a.iso Successfully updated media. # virsh dumpxml r7-vm1 | grep disk -A 9 <disk type='file' device='cdrom'> <driver name='qemu' type='raw'/> <source file='/var/lib/libvirt/images/a.iso' startupPolicy='optional'/> <backingStore/> <target dev='hdc' bus='ide'/> <readonly/> <alias name='ide0-1-0'/> <address type='drive' controller='0' bus='1' target='0' unit='0'/> </disk> As above, move this bug to verified. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-2202.html |