Bug 1230037

Summary: async simple paged results issue
Product: Red Hat Enterprise Linux 7 Reporter: Jan Kurik <jkurik>
Component: 389-ds-baseAssignee: Noriko Hosoi <nhosoi>
Status: CLOSED ERRATA QA Contact: Viktor Ashirov <vashirov>
Severity: high Docs Contact:
Priority: high    
Version: 7.0CC: nhosoi, nkinder, rmeggins, sramling, vanhoof
Target Milestone: rcKeywords: ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 389-ds-base-1.3.3.1-19.el7_1 Doc Type: Bug Fix
Doc Text:
Issue 1. Cause: Asynchronous simple paged results search request code was not thread safe. Consequence: There was a small window that the simple paged result slot was conflicted and it could crash the server. Fix: The code is now thread safe. Result: No more crash is observed. Issue 2. Cause: Abandoning simple paged results request was not handled correctly if an abandon is issued too quickly. Consequence: An internal search result object had a chance not to be released. Fix: At any timing an abandon request is issued, the search result request is safely released. Result: No more memory leak is observed.
Story Points: ---
Clone Of: 1228823 Environment:
Last Closed: 2015-08-05 19:23:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1228823    
Bug Blocks:    

Description Jan Kurik 2015-06-10 07:40:19 UTC
This bug has been copied from bug #1228823 and has been proposed
to be backported to 7.1 z-stream (EUS).

Comment 5 Noriko Hosoi 2015-06-10 20:45:22 UTC
Steps to verify:
https://bugzilla.redhat.com/show_bug.cgi?id=1228402#c4

Comment 6 Sankar Ramalingam 2015-06-29 12:35:02 UTC
1. No regression in simplepaged and filter acceptance tests
SIMPLEPAGED startup 	100% (1/1) 	  	 
SIMPLEPAGED run 	100% (17/17) 	  	 
SIMPLEPAGED cleanup 	100% (1/1)

filter startup 	100% (1/1) 	  	 
filter run 	100% (273/273) 	  	 
filter cleanup 	100% (2/2)

2. Proceeding with asynchronous simplepaged results.

Comment 7 Sankar Ramalingam 2015-06-29 12:35:57 UTC
[root@dhcp35-196 ~]# rpm -qa |grep -i 389-ds-base
389-ds-base-1.3.3.1-18.el7_1.x86_64
389-ds-base-libs-1.3.3.1-18.el7_1.x86_64

Comment 14 Noriko Hosoi 2015-07-02 17:56:41 UTC
Thank you so much for the valgrind output, Sankar.  It was very helpful.

Could you please try this scratch build with valgrind and see it changes the behaviour or not?
http://brewweb.devel.redhat.com/brew/taskinfo?taskID=9457717
Thanks!
--noriko

Comment 15 Sankar Ramalingam 2015-07-02 18:56:22 UTC
(In reply to Noriko Hosoi from comment #14)
> Thank you so much for the valgrind output, Sankar.  It was very helpful.
> 
> Could you please try this scratch build with valgrind and see it changes the
> behaviour or not?
> http://brewweb.devel.redhat.com/brew/taskinfo?taskID=9457717

I copied builds from the above brew link and updated them in the same machine. Then, I created a new instance and ran the same tests with valgrind. I will update the bug after few hours.
Instance port: 19589
Inst name - testinst3
Log file locn: --log-file=/var/tmp/val/slapd.vg.3344
> Thanks!
> --noriko

Comment 17 Noriko Hosoi 2015-07-02 20:04:13 UTC
Thank you so much for your quick action, Sankar!!

Comment 23 Sankar Ramalingam 2015-07-08 10:59:05 UTC
Stressed the server with the simplepaged search and I observed No crash. hence, marking the bug as Verified.

Build tested:
[root@qe-blade-12 ~]# rpm -qa |grep -i 389-ds-base389-ds-base-libs-1.3.3.1-19.el7_1.x86_64
389-ds-base-debuginfo-1.3.3.1-19.el7_1.x86_64
389-ds-base-1.3.3.1-19.el7_1.x86_64

Comment 25 errata-xmlrpc 2015-08-05 19:23:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1554.html