Bug 1230090

Summary:	[geo-rep]: use_meta_volume config option should be validated for its values
Product:	[Community] GlusterFS	Reporter:	Aravinda VK <avishwan>
Component:	geo-replication	Assignee:	Aravinda VK <avishwan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	avishwan, bugs, chrisw, csaba, gluster-bugs, nlevinki, nsathyan, rhinduja, storage-qa-internal
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1227618
Clones:	1230691 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:10:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1227618
Bug Blocks:	1223636, 1230691

Description Aravinda VK 2015-06-10 08:46:23 UTC

+++ This bug was initially created as a clone of Bug #1227618 +++

Description of problem:
=======================

use_meta_volume config option should be True/False, On/Off, 0/1, enable/disable. But currently it accepts all the values for example:


[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume xyz
geo-replication config updated successfully
[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume
xyz
[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume 0123
geo-replication config updated successfully
[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume
0123
[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config \!use_meta_volume 
geo-replication config updated successfully
[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume
[root@georep1 scripts]# 


Version-Release number of selected component (if applicable):
==============================================================

glusterfs-3.7.0-3.el6rhs.x86_64

How reproducible:
=================

Always


Steps to Reproduce:
===================
1. gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume xyz

Actual results:
===============

[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume xyz
geo-replication config updated successfully
[root@georep1 scripts]#

Expected results:
=================


[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume xyz
Invalid value(xyz) for option use_meta_volume
geo-replication command failed
[root@georep1 scripts]#

Comment 1 Aravinda VK 2015-06-10 08:49:47 UTC

Upstream patch sent
http://review.gluster.org/#/c/11156/

Comment 2 Anand Avati 2015-06-10 16:45:04 UTC

REVIEW: http://review.gluster.org/11156 (geo-rep: Validate use_meta_volume option) posted (#2) for review on master by Aravinda VK (avishwan)

Comment 3 Anand Avati 2015-06-11 06:40:51 UTC

REVIEW: http://review.gluster.org/11156 (geo-rep: Validate use_meta_volume option) posted (#3) for review on master by Aravinda VK (avishwan)

Comment 4 Anand Avati 2015-06-12 10:02:59 UTC

COMMIT: http://review.gluster.org/11156 committed in master by Vijay Bellur (vbellur) 
------
commit 57ecbbd6ce5b682a9e69c775ace48588d6535396
Author: Aravinda VK <avishwan>
Date:   Wed Jun 10 14:14:25 2015 +0530

    geo-rep: Validate use_meta_volume option
    
    Added validation for use_meta_volume option.
    
    Change-Id: I64cd9cb4bf383c7267638cab3837fd0cf89071c7
    Signed-off-by: Aravinda VK <avishwan>
    BUG: 1230090
    Reviewed-on: http://review.gluster.org/11156
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kotresh HR <khiremat>

Comment 5 Nagaprasad Sathyanarayana 2015-10-25 14:43:54 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 6 Niels de Vos 2016-06-16 13:10:41 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user