Bug 1230278

Created attachment 1037330 [details]
Fix for the problem.

Description of problem:

Specifying overstrike and underline colors in .mostrc have no effect.

Version-Release number of selected component (if applicable):

Fedora 22 on x86_64
most-5.0.0-10.a.1.fc22.x86_64

How reproducible:

Always

Steps to Reproduce:
1. dnf install most
2. echo 'normal brightgray black' > ~/.mostrc
3. echo 'color underline cyan black' >> ~/.mostrc
4. echo 'color overstrike yellow black' >> ~/.mostrc
5. echo 'color status black gray' >> ~/.mostrc
6. PAGER=most man most

Actual results:

Man page shown. Normal text light gray on black. Section headers ("NAME", "SYNOPSIS", "DESCRIPTION", others) are in red-on-black color. Program name ("most" in the text) is in green-on-black color. Status line is in black -on gray color.

Expected results:

Section headers ("NAME", "SYNOPSIS", "DESCRIPTION", others) are in yellow-on-black color. Program name ("most" in the text) is in cyan-on-black color.

Additional info:

See attached patch one-line. It may be implemented wrongly (or not completely — I have no idea about internal architecture of most), but it works for me. Note most_setup_colors function (line 285 of keyparse.c) — when setting up default colors, SLtt_set_color is called twice:

>    SLtt_set_color (h->value, NULL, h->fg, h->bg);
>    SLtt_set_color (h->value+MOST_EMBEDDED_COLOR_OFFSET, NULL, h->fg, h->bg);

And now see set_object_color function (line 206 of the same file) — SLtt_set_color is called once. Adding the second call (with +MOST_EMBEDDED_COLOR_OFFSET) helps — colors specified in .mostrc are works as expected.