Bug 1230690

Summary: Provisioning Dialogs accordion needs updates
Product: Red Hat CloudForms Management Engine Reporter: Dan Clarizio <dclarizi>
Component: UI - OPSAssignee: lgalis
Status: CLOSED ERRATA QA Contact: Jeff Teehan <jteehan>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.5.0CC: hkataria, jhardy, mpovolny, obarenbo
Target Milestone: GA   
Target Release: 5.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.5.0.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-08 13:13:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
All Dialogs right side list views
none
Current dialog list view
none
Dialog buttons none

Description Dan Clarizio 2015-06-11 11:29:17 UTC
Description of problem:
Selecting Provisioning Dialogs "All Dialogs" tree node should show all dialogs on the right.  Lists of Dialogs should show Description first (as shown in the tree), then Name.  Need to add Default column.  When showing a Dialog, the edit and delete buttons should be disabled with hover text that the user can not edit or delete a default Dialog.

Version-Release number of selected component (if applicable):


How reproducible:
Operate Provisioning Dialogs accordion

Actual results:
See attached screenshots

Comment 1 Dan Clarizio 2015-06-11 11:30:45 UTC
Created attachment 1037640 [details]
All Dialogs right side list views

All list views should be modified to show Description/Name/Default columns, initially sorted by Description to match the tree.

Comment 2 Dan Clarizio 2015-06-11 11:31:16 UTC
Created attachment 1037641 [details]
Current dialog list view

Comment 3 Dan Clarizio 2015-06-11 11:31:52 UTC
Created attachment 1037642 [details]
Dialog buttons

Need to disable some buttons if dialog.default is true

Comment 6 CFME Bot 2015-07-28 15:41:33 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/0053550fe5245a67fe4074250838414463880f85

commit 0053550fe5245a67fe4074250838414463880f85
Author:     Laura Galis <lgalis>
AuthorDate: Mon Jul 13 16:30:34 2015 -0400
Commit:     Laura Galis <lgalis>
CommitDate: Tue Jul 28 07:29:11 2015 -0400

    Provisioning Dialogs accordion needs updates
    
    Update the list for provisioning dialogs for 'All Dialogs' tab to list all dialogs not the categories.
    The Configuration toolbar menu for 'Default' Dialogs modified to not allow Edit and remove.
    Add the "Default' column to the dialogs list and reorder the columns.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1230690

 .../miq_ae_customization_controller/old_dialogs.rb        | 15 +++++++++------
 app/helpers/application_helper/toolbar_builder.rb         | 12 +++++++++++-
 app/helpers/application_helper/toolbar_chooser.rb         |  2 +-
 product/views/MiqDialog.yaml                              |  7 +++++--
 4 files changed, 26 insertions(+), 10 deletions(-)

Comment 7 Jeff Teehan 2015-10-01 17:08:43 UTC
Used 5.5.0.3  (https://10.8.59.195/miq_ae_customization/explorer) to verify.

I first checked the column headers to ensure they were correct.

Next, I check that for the default dialogs the Edit and Remove buttons had been disabled.

Lastly, I created my own custom dialog to verify that default was "False" and that the Edit and Delete buttons were properly enabled.  I also performed both an Edit and then a Delete to verify the above changes didn't bleed into custom dialogs.

Moving to Verified as all the conditions appear to have been met.

Comment 9 errata-xmlrpc 2015-12-08 13:13:19 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551