Bug 1230691

Summary: [geo-rep]: use_meta_volume config option should be validated for its values
Product: [Community] GlusterFS Reporter: Aravinda VK <avishwan>
Component: geo-replicationAssignee: Aravinda VK <avishwan>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.7.0CC: aavati, avishwan, bugs, csaba, gluster-bugs, nlevinki, nsathyan, rhinduja, storage-qa-internal
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.7.2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1230090 Environment:
Last Closed: 2015-06-20 09:50:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1227618, 1230090    
Bug Blocks: 1223636    

Description Aravinda VK 2015-06-11 11:36:38 UTC 
+++ This bug was initially created as a clone of Bug #1230090 +++

+++ This bug was initially created as a clone of Bug #1227618 +++

Description of problem:
=======================

use_meta_volume config option should be True/False, On/Off, 0/1, enable/disable. But currently it accepts all the values for example:


[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume xyz
geo-replication config updated successfully
[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume
xyz
[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume 0123
geo-replication config updated successfully
[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume
0123
[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config \!use_meta_volume 
geo-replication config updated successfully
[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume
[root@georep1 scripts]# 


Version-Release number of selected component (if applicable):
==============================================================

glusterfs-3.7.0-3.el6rhs.x86_64

How reproducible:
=================

Always


Steps to Reproduce:
===================
1. gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume xyz

Actual results:
===============

[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume xyz
geo-replication config updated successfully
[root@georep1 scripts]#

Expected results:
=================


[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave config use_meta_volume xyz
Invalid value(xyz) for option use_meta_volume
geo-replication command failed
[root@georep1 scripts]#

--- Additional comment from Aravinda VK on 2015-06-10 04:49:47 EDT ---

Upstream patch sent
http://review.gluster.org/#/c/11156/

--- Additional comment from Anand Avati on 2015-06-10 12:45:04 EDT ---

REVIEW: http://review.gluster.org/11156 (geo-rep: Validate use_meta_volume option) posted (#2) for review on master by Aravinda VK (avishwan)

--- Additional comment from Anand Avati on 2015-06-11 02:40:51 EDT ---

REVIEW: http://review.gluster.org/11156 (geo-rep: Validate use_meta_volume option) posted (#3) for review on master by Aravinda VK (avishwan)
Comment 1 Anand Avati 2015-06-11 11:43:10 UTC 
REVIEW: http://review.gluster.org/11180 (geo-rep: Validate use_meta_volume option) posted (#1) for review on release-3.7 by Aravinda VK (avishwan)
Comment 2 Anand Avati 2015-06-12 18:32:52 UTC 
COMMIT: http://review.gluster.org/11180 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit 2e0c8bbe9a04693c270fd383a2a58f3ef87fb898
Author: Aravinda VK <avishwan>
Date:   Wed Jun 10 14:14:25 2015 +0530

    geo-rep: Validate use_meta_volume option
    
    Added validation for use_meta_volume option.
    
    Change-Id: I64cd9cb4bf383c7267638cab3837fd0cf89071c7
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/#/c/11156/
    BUG: 1230691
    Reviewed-on: http://review.gluster.org/11180
    Reviewed-by: Kotresh HR <khiremat>
    Tested-by: Gluster Build System <jenkins.com>
Comment 3 Niels de Vos 2015-06-20 09:50:45 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.2, please reopen this bug report.

glusterfs-3.7.2 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/packaging/2015-June/000006.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user