Bug 1230715

Summary:	[Backup]: Glusterfind delete does not delete the session related information present in $GLUSTERD_WORKDIR
Product:	[Community] GlusterFS	Reporter:	Aravinda VK <avishwan>
Component:	glusterfind	Assignee:	Aravinda VK <avishwan>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	medium	Docs Contact:
Priority:	low
Version:	3.7.0	CC:	avishwan, bugs, khiremat, mchangir, sanandpa
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1230111	Environment:
Last Closed:	2015-06-20 09:50:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1229623, 1230111
Bug Blocks:	1223636

Description Aravinda VK 2015-06-11 12:41:00 UTC

+++ This bug was initially created as a clone of Bug #1230111 +++

+++ This bug was initially created as a clone of Bug #1229623 +++

Description of problem:

When we choose to not go ahead with a particular session, we use glusterfind delete to delete the entry from the list. However, that leaves the session directory and all the information under it (at the location /var/lib/glusterd/glusterfind/) intact. 

True, it doesn't hamper or come in the way of creating another session with the same name, but it does lead to unnecessary confusion. 

Same is the case with LOGS at /var/log/glusterfs/glusterfind/. But we would want to store the logs for some later point of time in future. 

Version-Release number of selected component (if applicable):
glusterfs-3.7.0-3.el6rhs.x86_64

How reproducible: Always


Steps to Reproduce:
1. Have a 2node cluster, create a volume 'ozone' and a glusterfind session 'sesso1'
2. Run pre and post a couple of times
3. Execute glusterfind delete to delete the session 'sesso1'
4. Check the contents of /var/lib/glusterd/glusterfind/sesso1/ozone

Actual results:

Step4 displays the status information related to 'sesso1'

Expected results:

Glusterfind delete should delete teh directory 'sesso1' and its entire contents

--- Additional comment from Aravinda VK on 2015-06-09 13:25:36 EDT ---

Since stale directories observed only in backend and not exposed to user. Moving the priority to LOW.

--- Additional comment from Anand Avati on 2015-06-10 05:31:31 EDT ---

REVIEW: http://review.gluster.org/11157 (tools/glusterfind: Cleanup session dir after delete) posted (#1) for review on master by Aravinda VK (avishwan)

--- Additional comment from Anand Avati on 2015-06-10 12:44:39 EDT ---

REVIEW: http://review.gluster.org/11157 (tools/glusterfind: Cleanup session dir after delete) posted (#2) for review on master by Aravinda VK (avishwan)

--- Additional comment from Anand Avati on 2015-06-11 02:41:58 EDT ---

REVIEW: http://review.gluster.org/11157 (tools/glusterfind: Cleanup session dir after delete) posted (#3) for review on master by Aravinda VK (avishwan)

Comment 1 Anand Avati 2015-06-11 12:44:34 UTC

REVIEW: http://review.gluster.org/11185 (tools/glusterfind: Cleanup session dir after delete) posted (#1) for review on release-3.7 by Aravinda VK (avishwan)

Comment 2 Anand Avati 2015-06-11 16:14:24 UTC

REVIEW: http://review.gluster.org/11185 (tools/glusterfind: Cleanup session dir after delete) posted (#2) for review on release-3.7 by Aravinda VK (avishwan)

Comment 3 Anand Avati 2015-06-12 18:33:23 UTC

COMMIT: http://review.gluster.org/11185 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit e444c8f454aa791aa723016ceaa66d9eb2971dc0
Author: Aravinda VK <avishwan>
Date:   Wed Jun 10 14:47:21 2015 +0530

    tools/glusterfind: Cleanup session dir after delete
    
    Sessions directories are created in
    /var/lib/glusterd/glusterfind/<SESSION>/<VOLUME>, only <VOLUME>
    dir is created since same session name can exists for two volumes.
    
    Now cleanup is added, <SESSION> dir will be removed if <SESSION>
    contains only one Volume.
    
    Change-Id: I236393659e63eb98342570e0255739f4adea4491
    Signed-off-by: Aravinda VK <avishwan>
    BUG: 1230715
    Reviewed-on: http://review.gluster.org/#/c/11157/
    Reviewed-on: http://review.gluster.org/11185
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kotresh HR <khiremat>

Comment 4 Niels de Vos 2015-06-20 09:50:58 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.2, please reopen this bug report.

glusterfs-3.7.2 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/packaging/2015-June/000006.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user