Bug 1230813
Summary: | Unable to add label to bond0 when trunk contains additional VLANs which are used to register the host to RHEV-M | |||
---|---|---|---|---|
Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Simon Reber <sreber> | |
Component: | ovirt-engine | Assignee: | Marcin Mirecki <mmirecki> | |
Status: | CLOSED ERRATA | QA Contact: | Meni Yakove <myakove> | |
Severity: | medium | Docs Contact: | ||
Priority: | high | |||
Version: | 3.5.1 | CC: | alkaplan, bazulay, danken, gklein, juan.hernandez, lpeer, lsurette, masayag, mburman, rbalakri, Rhev-m-bugs, sherold, yeylon, ykaul, ylavi | |
Target Milestone: | ovirt-3.6.0-rc3 | Keywords: | Reopened, ZStream | |
Target Release: | 3.6.0 | Flags: | ylavi:
Triaged+
|
|
Hardware: | x86_64 | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 1241055 (view as bug list) | Environment: | ||
Last Closed: | 2016-03-09 21:07:31 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | 1136329 | |||
Bug Blocks: | 1241055 |
Description
Simon Reber
2015-06-11 14:49:11 UTC
The RESTAPI operation to add a label is extremely simple, it just invokes the backend LabelNic command passing the NIC identifier and label. So chances are that the issue is in the backend. I'm changing the component accordingly. Forgot to add, the following messages are found when the operation fails: 2015-06-03 12:16:50,716 WARN [org.ovirt.engine.core.bll.network.host.SetupNetworksCommand] (ajp-/127.0.0.1:8702-1) [5d063f8c] CanDoAction of action SetupNetworks failed for user admin@internal. Reasons: VAR__ACTION__SETUP,VAR__TYPE__NETWORKS,NETWORK_INTERFACES_ALREADY_SPECIFIED,$NETWORK_INTERFACES_ALREADY_SPECIFIED_LIST bond0.1710 2015-06-03 12:16:50,718 ERROR [org.ovirt.engine.core.bll.network.host.LabelNicCommand] (ajp-/127.0.0.1:8702-1) [5d063f8c] Transaction rolled-back for command: org.ovirt.engine.core.bll.network.host.LabelNicCommand. 2015-06-03 12:16:50,722 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp-/127.0.0.1:8702-1) [5d063f8c] Correlation ID: 35e19111, Call Stack: null, Custom Event ID: -1, Message: Failed to label network interface card bond0 with label fiber on host hvm-lab10ch-3.mgmt.sccloudpoc.net. 2015-06-03 12:16:50,723 ERROR [org.ovirt.engine.api.restapi.resource.AbstractBackendResource] (ajp-/127.0.0.1:8702-1) Operation Failed: [Cannot add Label. The following Network Interfaces were specified more than once: bond0.1710.] I reproduced this in my environment, following the instructions in the description. Looking at the code I see that when adding the label the required networks are also added. If they are VLANs then the corresponding VLAN device is created on top of the bond without first checking if it already exists. From the NetworkParametersBuilder class: protected void configureNetwork(VdsNetworkInterface nic, List<VdsNetworkInterface> nics, Network network) { NetworkCluster networkCluster = getNetworkCluster(nic, network); if (NetworkUtils.isVlan(network)) { VdsNetworkInterface vlan = createVlanDevice(nic, network); // This ^ creates a new VLAN device on top of the bond without // taking into account that it may already exists. The result // is a duplicated device name that will be later rejected. addBootProtocolForRoleNetwork(networkCluster, vlan); nics.add(vlan); } ... } Note also that the GUI doesn't use the LabelNic command, it calls directly the SetupNetworks command, that is why this problem doesn't affect the GUI. Do we need to provide further information or is the information from Juan Hernández (https://bugzilla.redhat.com/show_bug.cgi?id=1230813#c3) sufficient to identify and fix the issue? This looks like a duplicate of https://bugzilla.redhat.com/1241055 That was fixed for 3.5 I do not see this error happening in master. The error message: The following Network Interfaces were specified more than once is reachable only from SetupNetworksCommand, which was replaced by HostSetupNetworksCommand in master/3.6, so it should not be visible in master/3.6 Should work using the new HostSetupNetworks command. Why did you reopen this? (In reply to Yaniv Dary from comment #12) > Why did you reopen this? I moved it to closed by mistake. I want the qe to verify it works in 3.6. Verified on - rhevm-3.6.0.1-0.1.el6.noarch and vdsm-4.17.9-1.el7ev.noarch Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHEA-2016-0376.html |