Bug 1230965 (php-doctrine-doctrine-cache-bundle)
| Summary: | Review Request: php-doctrine-doctrine-cache-bundle - Symfony Bundle for Doctrine Cache | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, package-review | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | php-doctrine-doctrine-cache-bundle-1.0.1-2.el7 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-06-22 18:11:53 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1230967 | ||||||||
| Attachments: |
|
||||||||
|
Description
Shawn Iwinski
2015-06-11 21:49:06 UTC
Shouldn't your autoloader also manage dependency ? (ok, setUseIncludePath should allow this, but only as a fallback) I forget to ask, why don't you requires the dependencies from "requires" in composer.json ?
"require": {
"php": ">=5.3.2",
"symfony/security": "~2.2",
"symfony/doctrine-bridge": "~2.2",
"doctrine/inflector": "~1.0",
"doctrine/cache": "~1.3"
(In reply to Remi Collet from comment #1) > Shouldn't your autoloader also manage dependency ? > (ok, setUseIncludePath should allow this, but only as a fallback) I haven't updated all packages to provide their own autoloader yet so I am using the include path as a fallback for now and I will update when I can. (In reply to Remi Collet from comment #2) > I forget to ask, why don't you requires the dependencies from "requires" in > composer.json ? > > "require": { > "php": ">=5.3.2", > "symfony/security": "~2.2", > "symfony/doctrine-bridge": "~2.2", > "doctrine/inflector": "~1.0", > "doctrine/cache": "~1.3" I just totally screwed up the dependencies! THANKS for catching that! Fixed. Diff: https://github.com/siwinski/rpms/commit/428617de6f7b50c4fb4f64a012edcf8103ad0bd6 Spec URL: https://raw.githubusercontent.com/siwinski/rpms/428617de6f7b50c4fb4f64a012edcf8103ad0bd6/php-doctrine-doctrine-cache-bundle/php-doctrine-doctrine-cache-bundle.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-doctrine-doctrine-cache-bundle-1.0.1-2.fc22.src.rpm Created attachment 1040314 [details]
phpci.log
phpCompatInfo version 4.3.0 DB built Jun 16 2015 12:10:27 CEST static analyze results
Created attachment 1040315 [details]
review.txt
Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Everything seems OK. === APPROVED === THANKS for the review! New Package SCM Request ======================= Package Name: php-doctrine-doctrine-cache-bundle Short Description: Symfony Bundle for Doctrine Cache Upstream URL: https://github.com/doctrine/DoctrineCacheBundle Owners: siwinski Branches: f21 f22 el6 epel7 InitialCC: Git done (by process-git-requests). php-doctrine-doctrine-cache-bundle-1.0.1-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-doctrine-doctrine-cache-bundle-1.0.1-2.fc21 php-doctrine-doctrine-cache-bundle-1.0.1-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/php-doctrine-doctrine-cache-bundle-1.0.1-2.fc22 php-doctrine-doctrine-cache-bundle-1.0.1-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/php-doctrine-doctrine-cache-bundle-1.0.1-2.el7 php-doctrine-doctrine-cache-bundle-1.0.1-2.fc22 has been pushed to the Fedora 22 stable repository. php-doctrine-doctrine-cache-bundle-1.0.1-2.fc21 has been pushed to the Fedora 21 stable repository. php-doctrine-doctrine-cache-bundle-1.0.1-2.el7 has been pushed to the Fedora EPEL 7 stable repository. |