Bug 1231040

Summary:	gf_log_callingfn's output make me dizzy
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	logging	Assignee:	Ravishankar N <ravishankar>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-07-29 15:11:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ravishankar N 2015-06-12 05:26:39 UTC

Description of problem:

I am finding it difficult to decipher the backtrace generated by gf_log_callingfn which prints everything in one line:

[2015-06-11 13:43:05.060464] W [dict.c:499:dict_ref] (--> /usr/local/lib/libglusterfs.so.0(_gf_log_callingfn+0x218)[0x7fcaa9fe9d4a] (--> /usr/loc    al/lib/libglusterfs.so.0(dict_ref+0x44)[0x7fcaa9fe15d1] (--> /usr/local/lib/libglusterfs.so.0(syncop_getxattr_cbk+0x54)[0x7fcaaa03d5c8] (--> /usr    /local/lib/glusterfs/3.6.4beta1/xlator/cluster/replicate.so(afr_get_heal_info+0x2b9)[0x7fca9c8c64d9] (--> /usr/local/lib/glusterfs/3.6.4beta1/xla    tor/cluster/replicate.so(afr_getxattr+0x45b)[0x7fca9c883542] ))))) 0-dict: dict is NULL


Expected results:
A back trace should look like a back trace, with one function per line.


Additional info:
The feeling is like staring into this image for a long time: http://commons.wikimedia.org/wiki/File:Peripheral_drift_illusion_rotating_snakes.svg

Comment 1 Anand Avati 2015-06-15 05:27:50 UTC

REVIEW: http://review.gluster.org/11217 (libglusterfs: pretty print gf_log_callingfn) posted (#1) for review on master by Ravishankar N (ravishankar)

Comment 2 Anand Avati 2015-07-22 06:04:33 UTC

REVIEW: http://review.gluster.org/11217 (libglusterfs: pretty print gf_log_callingfn) posted (#2) for review on master by Ravishankar N (ravishankar)

Comment 3 Ravishankar N 2015-07-29 15:11:00 UTC

Please see patch for review comments/ links to  discussion on mailing list.