Bug 1231368
| Summary: | python-tornado: requirement of ssl_match_hostname is no longer needed since Python 2.7.9 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Carl George <carl> |
| Component: | python-tornado | Assignee: | Python SIG <python-sig> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 22 | CC: | mhroncok, orion, python-sig, tomspur |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | python-tornado-3.2.2-2.fc22 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-07-23 08:59:43 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1229409 | ||
python-tornado-3.2.2-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-tornado-3.2.2-2.fc22 Package python-tornado-3.2.2-2.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-tornado-3.2.2-2.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-11487/python-tornado-3.2.2-2.fc22 then log in and leave karma (feedback). python-tornado-3.2.2-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: Python 3.4's entire ssl module was backported to 2.7.9 [1]. Tornado already has a conditional statement to import CertificateError and match_hostname from the standard library ssl module if they are available [2]. Effectively, the rpm has a dependency that isn't being used. Because of that, I believe that these lines should be removed from the python-tornado spec file [3]. -BuildRequires: python-backports-ssl_match_hostname -Requires: python-backports-ssl_match_hostname Version-Release number of selected component (if applicable): python-tornado-3.2.2-1.fc22 How reproducible: $ # CertificateError in the standard library $ grep 'class CertificateError' /usr/lib64/python2.7/ssl.py class CertificateError(ValueError): $ # match_hostname in the standard library $ grep 'def match_hostname' /usr/lib64/python2.7/ssl.py def match_hostname(cert, hostname): $ # tornado tries to import from the standard library first $ grep -B4 backports /usr/lib64/python2.7/site-packages/tornado/netutil.py if hasattr(ssl, 'match_hostname') and hasattr(ssl, 'CertificateError'): # python 3.2+ ssl_match_hostname = ssl.match_hostname SSLCertificateError = ssl.CertificateError else: import backports.ssl_match_hostname ssl_match_hostname = backports.ssl_match_hostname.match_hostname SSLCertificateError = backports.ssl_match_hostname.CertificateError Actual results: The RPM has a dependency that it isn't using. Expected results: The RPM only depends on things it actually needs. Additional info: [1] https://www.python.org/downloads/release/python-279/ [2] https://github.com/tornadoweb/tornado/blob/v3.2.2/tornado/netutil.py#L32-L38 [3] http://pkgs.fedoraproject.org/cgit/python-tornado.git/tree/python-tornado.spec#n20