Bug 1231570

Summary: Review Request: Java-WebSocket - A barebones WebSocket client and server implementation written in 100% Java
Product: [Fedora] Fedora Reporter: Jonny Heggheim <hegjon>
Component: Package ReviewAssignee: gil cattaneo <puntogil>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: akurtako, package-review, puntogil
Target Milestone: ---Flags: puntogil: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-10-03 23:57:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jonny Heggheim 2015-06-14 20:26:05 UTC 
Spec URL: https://raw.githubusercontent.com/hegjon/Java-WebSocket-rpm/master/Java-WebSocket.spec
SRPM URL: https://raw.githubusercontent.com/hegjon/Java-WebSocket-rpm/master/Java-WebSocket-1.3.0-1.fc22.src.rpm
Description: A barebones WebSocket server and client implementation written in 100% Java.
The underlying classes are implemented java.nio, which allows for a non-blocking
event-driven model (similar to the WebSocket API for web browsers).
Fedora Account System Username: jonny

Koji build link: http://koji.fedoraproject.org/koji/taskinfo?taskID=10053747

I need a sponsor. This is my third package, but my other packages have not been accepted yet.
Comment 1 Jonny Heggheim 2015-06-14 20:27:38 UTC 
I wanted to use java-websocket as packagename, but I see that upstream uses CamelCase a lot. Not sure what is best..
Comment 2 gil cattaneo 2015-06-15 01:12:07 UTC 
There are some bundle libraries in the source archive:
dist/java_websocket.jar
gradle/wrapper/gradle-wrapper.jar
src/main/example/prototype.js
src/main/example/web-socket-js/swfobject.js
src/main/example/web-socket-js/web_socket.js

src/main/example/web-socket-js/WebSocketMain.swf

please, use for remove them
find -name "*.jar" -delete
find -name "*.js" -delete
find -name "*.swf" -delete
Comment 3 Jonny Heggheim 2015-06-15 07:37:13 UTC 
Added your suggestions + also removed the rest of gradle wrapper
Comment 4 Jonny Heggheim 2015-06-16 06:18:43 UTC 
Upstream informed
Comment 5 Alexander Kurtakov 2015-08-17 14:25:22 UTC 
Removing FE-NEEDSPONSOR as I sponsored Jonny.
Comment 6 gil cattaneo 2015-08-17 14:53:08 UTC 
Build fails

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.10.3:jar (attach-javadocs) on project Java-WebSocket: MavenReportException: Error while generating Javadoc:
[ERROR] Exit code: 1 - /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WrappedByteChannel.java:19: warning: no @return
[ERROR] public boolean isNeedRead();
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WrappedByteChannel.java:24: warning: no @param for dst
[ERROR] public int readMore( ByteBuffer dst ) throws SSLException;
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WrappedByteChannel.java:24: warning: no @return
[ERROR] public int readMore( ByteBuffer dst ) throws SSLException;
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WrappedByteChannel.java:24: warning: no @throws for javax.net.ssl.SSLException
[ERROR] public int readMore( ByteBuffer dst ) throws SSLException;
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/SocketChannelIOHelper.java:26: warning: no @param for buf
[ERROR] public static boolean readMore( final ByteBuffer buf, WebSocketImpl ws, WrappedByteChannel channel ) throws IOException {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/SocketChannelIOHelper.java:26: warning: no @param for ws
[ERROR] public static boolean readMore( final ByteBuffer buf, WebSocketImpl ws, WrappedByteChannel channel ) throws IOException {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/SocketChannelIOHelper.java:26: warning: no @param for channel
[ERROR] public static boolean readMore( final ByteBuffer buf, WebSocketImpl ws, WrappedByteChannel channel ) throws IOException {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/SocketChannelIOHelper.java:26: warning: no @throws for java.io.IOException
[ERROR] public static boolean readMore( final ByteBuffer buf, WebSocketImpl ws, WrappedByteChannel channel ) throws IOException {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/SocketChannelIOHelper.java:39: warning: no @param for ws
[ERROR] public static boolean batch( WebSocketImpl ws, ByteChannel sockchannel ) throws IOException {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/SocketChannelIOHelper.java:39: warning: no @param for sockchannel
[ERROR] public static boolean batch( WebSocketImpl ws, ByteChannel sockchannel ) throws IOException {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/SocketChannelIOHelper.java:39: warning: no @return
[ERROR] public static boolean batch( WebSocketImpl ws, ByteChannel sockchannel ) throws IOException {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/SocketChannelIOHelper.java:39: warning: no @throws for java.io.IOException
[ERROR] public static boolean batch( WebSocketImpl ws, ByteChannel sockchannel ) throws IOException {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocket.java:32: warning: no @param for code
[ERROR] public void close( int code, String message );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocket.java:32: warning: no @param for message
[ERROR] public void close( int code, String message );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocket.java:43: warning: no @param for code
[ERROR] public abstract void closeConnection( int code, String message );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocket.java:43: warning: no @param for message
[ERROR] public abstract void closeConnection( int code, String message );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocket.java:48: warning: no description for @throws
[ERROR] * @throws IllegalArgumentException
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocket.java:49: warning: no description for @throws
[ERROR] * @throws NotYetConnectedException
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocket.java:51: warning: no @param for text
[ERROR] public abstract void send( String text ) throws NotYetConnectedException;
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocket.java:56: warning: no description for @throws
[ERROR] * @throws IllegalArgumentException
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocket.java:57: warning: no description for @throws
[ERROR] * @throws NotYetConnectedException
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocket.java:59: warning: no @param for bytes
[ERROR] public abstract void send( ByteBuffer bytes ) throws IllegalArgumentException , NotYetConnectedException;
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocket.java:68: error: unknown tag: returns
[ERROR] * @returns never returns null
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocket.java:70: warning: no @return
[ERROR] public abstract InetSocketAddress getRemoteSocketAddress();
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocket.java:73: error: unknown tag: returns
[ERROR] * @returns never returns null
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocket.java:75: warning: no @return
[ERROR] public abstract InetSocketAddress getLocalSocketAddress();
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocket.java:87: warning: no @return
[ERROR] public abstract boolean isFlushAndClose();
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocket.java:90: warning: no @return
[ERROR] public abstract boolean isClosed();
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketAdapter.java:66: error: no content
[ERROR] * @see @see org.java_websocket.WebSocketListener#onWebsocketPong(WebSocket, Framedata)
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketAdapter.java:69: warning - Tag @see:illegal character: "64" in "@see org.java_websocket.WebSocketListener#onWebsocketPong(WebSocket, Framedata)"
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:98: warning: no @param for d
[ERROR] public void onWebsocketOpen( WebSocket conn, Handshakedata d );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:104: error: @param name not found
[ERROR] * @param conn
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:107: warning: no @param for ws
[ERROR] public void onWebsocketClose( WebSocket ws, int code, String reason, boolean remote );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:107: warning: no @param for code
[ERROR] public void onWebsocketClose( WebSocket ws, int code, String reason, boolean remote );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:107: warning: no @param for reason
[ERROR] public void onWebsocketClose( WebSocket ws, int code, String reason, boolean remote );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:107: warning: no @param for remote
[ERROR] public void onWebsocketClose( WebSocket ws, int code, String reason, boolean remote );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:110: warning: no @param for ws
[ERROR] public void onWebsocketClosing( WebSocket ws, int code, String reason, boolean remote );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:110: warning: no @param for code
[ERROR] public void onWebsocketClosing( WebSocket ws, int code, String reason, boolean remote );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:110: warning: no @param for reason
[ERROR] public void onWebsocketClosing( WebSocket ws, int code, String reason, boolean remote );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:110: warning: no @param for remote
[ERROR] public void onWebsocketClosing( WebSocket ws, int code, String reason, boolean remote );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:113: warning: no @param for ws
[ERROR] public void onWebsocketCloseInitiated( WebSocket ws, int code, String reason );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:113: warning: no @param for code
[ERROR] public void onWebsocketCloseInitiated( WebSocket ws, int code, String reason );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:113: warning: no @param for reason
[ERROR] public void onWebsocketCloseInitiated( WebSocket ws, int code, String reason );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:123: warning: no @param for conn
[ERROR] public void onWebsocketError( WebSocket conn, Exception ex );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:132: warning: no @param for conn
[ERROR] public void onWebsocketPing( WebSocket conn, Framedata f );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:137: warning: no @param for conn
[ERROR] public void onWebsocketPong( WebSocket conn, Framedata f );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:137: warning: no @param for f
[ERROR] public void onWebsocketPong( WebSocket conn, Framedata f );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:143: warning: no @param for conn
[ERROR] public String getFlashPolicy( WebSocket conn );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:143: warning: no @return
[ERROR] public String getFlashPolicy( WebSocket conn );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketListener.java:146: warning: no @param for conn
[ERROR] public void onWriteDemand( WebSocket conn );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketImpl.java:149: warning: no @param for socketBuffer
[ERROR] public void decode( ByteBuffer socketBuffer ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketImpl.java:442: warning: no @param for code
[ERROR] protected synchronized void closeConnection( int code, String message, boolean remote ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketImpl.java:442: warning: no @param for message
[ERROR] protected synchronized void closeConnection( int code, String message, boolean remote ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketImpl.java:536: warning: no description for @throws
[ERROR] * @throws IllegalArgumentException
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketImpl.java:537: warning: no description for @throws
[ERROR] * @throws NotYetConnectedException
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketImpl.java:549: warning: no description for @throws
[ERROR] * @throws IllegalArgumentException
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketImpl.java:550: warning: no description for @throws
[ERROR] * @throws NotYetConnectedException
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketImpl.java:122: error: @param name not found
[ERROR] * @param socket
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketImpl.java:125: warning: no @param for listener
[ERROR] public WebSocketImpl( WebSocketListener listener , Draft draft ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketImpl.java:125: warning: no @param for draft
[ERROR] public WebSocketImpl( WebSocketListener listener , Draft draft ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketImpl.java:108: warning: no @param for listener
[ERROR] public WebSocketImpl( WebSocketListener listener , List<Draft> drafts ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/WebSocketImpl.java:108: warning: no @param for drafts
[ERROR] public WebSocketImpl( WebSocketListener listener , List<Draft> drafts ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/framing/FramedataImpl1.java:29: warning: no @param for f
[ERROR] public FramedataImpl1( Framedata f ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/drafts/Draft.java:177: warning: no @return
[ERROR] public abstract Draft copyInstance();
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/client/DefaultWebSocketClientFactory.java:20: warning: no description for @param
[ERROR] * @param webSocketClient
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/client/WebSocketClient.java:127: warning: no @return
[ERROR] public Draft getDraft() {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/client/WebSocketClient.java:147: warning: no @return
[ERROR] public boolean connectBlocking() throws InterruptedException {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/client/WebSocketClient.java:147: warning: no @throws for java.lang.InterruptedException
[ERROR] public boolean connectBlocking() throws InterruptedException {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/client/WebSocketClient.java:300: warning: no @return
[ERROR] public READYSTATE getReadyState() {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/client/WebSocketClient.java:307: warning: no description for @param
[ERROR] * @param conn
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/client/WebSocketClient.java:308: warning: no description for @param
[ERROR] * @param message
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/client/WebSocketClient.java:323: warning: no description for @param
[ERROR] * @param conn
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/client/WebSocketClient.java:334: warning: no description for @param
[ERROR] * @param conn
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/client/WebSocketClient.java:348: warning: no description for @param
[ERROR] * @param conn
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/client/WebSocketClient.java:84: warning: no @param for serverUri
[ERROR] public WebSocketClient( URI serverUri , Draft draft ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/client/WebSocketClient.java:84: warning: no @param for draft
[ERROR] public WebSocketClient( URI serverUri , Draft draft ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:682: warning: no @param for channel
[ERROR] public ByteChannel wrapChannel( SocketChannel channel, SelectionKey key ) throws IOException;
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:682: warning: no @throws for java.io.IOException
[ERROR] public ByteChannel wrapChannel( SocketChannel channel, SelectionKey key ) throws IOException;
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:178: warning: no description for @throws
[ERROR] * @throws IllegalStateException
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:198: warning: no description for @throws
[ERROR] * @throws InterruptedException
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:507: warning: no @param for ws
[ERROR] protected boolean removeConnection( WebSocket ws ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:507: warning: no @return
[ERROR] protected boolean removeConnection( WebSocket ws ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:514: warning: no @param for ws
[ERROR] protected boolean addConnection( WebSocket ws ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:514: warning: no @return
[ERROR] protected boolean addConnection( WebSocket ws ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:571: error: unexpected content
[ERROR] * @see {@link #onOpen(WebSocket, ClientHandshake)}, {@link #onWebsocketHandshakeReceivedAsServer(WebSocket, Draft, ClientHandshake)}
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:573: warning: no @param for key
[ERROR] protected boolean onConnect( SelectionKey key ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:573: warning: no @return
[ERROR] protected boolean onConnect( SelectionKey key ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:573: warning - Tag @see:illegal character: "123" in "{@link #onOpen(WebSocket, ClientHandshake)}, {@link #onWebsocketHandshakeReceivedAsServer(WebSocket, Draft, ClientHandshake)}"
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:573: warning - Tag @see:illegal character: "64" in "{@link #onOpen(WebSocket, ClientHandshake)}, {@link #onWebsocketHandshakeReceivedAsServer(WebSocket, Draft, ClientHandshake)}"
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:593: warning: no @param for conn
[ERROR] public abstract void onOpen( WebSocket conn, ClientHandshake handshake );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:593: warning: no @param for handshake
[ERROR] public abstract void onOpen( WebSocket conn, ClientHandshake handshake );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:604: warning: no @param for conn
[ERROR] public abstract void onClose( WebSocket conn, int code, String reason, boolean remote );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:610: warning: no @param for conn
[ERROR] public abstract void onMessage( WebSocket conn, String message );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:610: warning: no @param for message
[ERROR] public abstract void onMessage( WebSocket conn, String message );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:616: error: @param name not found
[ERROR] * @param con
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:619: warning: no @param for conn
[ERROR] public abstract void onError( WebSocket conn, Exception ex );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:619: warning: no @param for ex
[ERROR] public abstract void onError( WebSocket conn, Exception ex );
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:625: warning: no @param for conn
[ERROR] public void onMessage( WebSocket conn, ByteBuffer message ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:625: warning: no @param for message
[ERROR] public void onMessage( WebSocket conn, ByteBuffer message ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:93: warning: no @throws for java.net.UnknownHostException
[ERROR] public WebSocketServer() throws UnknownHostException {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:102: warning: no @param for address
[ERROR] public WebSocketServer( InetSocketAddress address ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:109: warning: no @param for address
[ERROR] public WebSocketServer( InetSocketAddress address , int decoders ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:109: warning: no @param for decoders
[ERROR] public WebSocketServer( InetSocketAddress address , int decoders ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:123: warning: no @param for address
[ERROR] public WebSocketServer( InetSocketAddress address , int decodercount , List<Draft> drafts ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:123: warning: no @param for decodercount
[ERROR] public WebSocketServer( InetSocketAddress address , int decodercount , List<Draft> drafts ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:123: warning: no @param for drafts
[ERROR] public WebSocketServer( InetSocketAddress address , int decodercount , List<Draft> drafts ) {
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:145: error: element not closed: a
[ERROR] * @see <a href="https://github.com/TooTallNate/Java-WebSocket/wiki/Drafts" > more about drafts
[ERROR] ^
[ERROR] /builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/src/main/java/org/java_websocket/server/WebSocketServer.java:147: warning - Tag @see: missing final '>': "<a href="https://github.com/TooTallNate/Java-WebSocket/wiki/Drafts" > more about drafts"
[ERROR] 
[ERROR] Command line was: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.60-11.b24.fc24.i386/jre/../bin/javadoc @options @packages
[ERROR] 
[ERROR] Refer to the generated Javadoc files in '/builddir/build/BUILD/Java-WebSocket-Java-WebSocket-1.3.0/target/apidocs' dir.
[ERROR] -> [Help 1]

Please, add:

%pom_remove_plugin :maven-javadoc-plugin

for prevent javadoc doclint failure

and

%pom_remove_plugin :maven-source-plugin
we dont need this artifact... ?
Comment 7 Jonny Heggheim 2015-08-19 09:46:54 UTC 
Created bug report about missing license header in source files: https://github.com/TooTallNate/Java-WebSocket/issues/336
Comment 8 Jonny Heggheim 2015-08-19 11:16:59 UTC 
> %pom_remove_plugin :maven-javadoc-plugin
> for prevent javadoc doclint failure
Thanks, fixed. I did not know that Java 8 was different between f22 and f23. 

and

> %pom_remove_plugin :maven-source-plugin
> we dont need this artifact... ?
We do not need it, removed it.
Comment 9 gil cattaneo 2015-08-19 11:33:54 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[?]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 52 files have unknown license. Detailed
     output of licensecheck in /home/gil/1231570-Java-WebSocket/results
     /review-Java-WebSocket/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
     Note: Using prebuilt rpms.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
     Note: Macros in: Java-WebSocket (summary), Java-WebSocket
     (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It
     is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
     when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in Java-
     WebSocket-javadoc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: Java-WebSocket-1.3.0-1.fc24.noarch.rpm
          Java-WebSocket-javadoc-1.3.0-1.fc24.noarch.rpm
          Java-WebSocket-1.3.0-1.fc24.src.rpm
Java-WebSocket.noarch: W: spelling-error Summary(en_US) barebones -> bare bones, bare-bones, baronesses
Java-WebSocket.noarch: W: spelling-error %description -l en_US barebones -> bare bones, bare-bones, baronesses
Java-WebSocket.noarch: W: spelling-error %description -l en_US nio -> bio, nip, no
Java-WebSocket.src: W: spelling-error Summary(en_US) barebones -> bare bones, bare-bones, baronesses
Java-WebSocket.src: W: spelling-error %description -l en_US barebones -> bare bones, bare-bones, baronesses
Java-WebSocket.src: W: spelling-error %description -l en_US nio -> bio, nip, no
3 packages and 0 specfiles checked; 0 errors, 6 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: File o directory non esistente
2 packages and 0 specfiles checked; 0 errors, 0 warnings.



Requires
--------
Java-WebSocket (rpmlib, GLIBC filtered):
    java-headless
    jpackage-utils
    mvn(net.iharder:base64)

Java-WebSocket-javadoc (rpmlib, GLIBC filtered):
    jpackage-utils



Provides
--------
Java-WebSocket:
    Java-WebSocket
    mvn(org.java-websocket:Java-WebSocket)
    mvn(org.java-websocket:Java-WebSocket:pom:)

Java-WebSocket-javadoc:
    Java-WebSocket-javadoc



Source checksums
----------------
https://github.com/TooTallNate/Java-WebSocket/archive/Java-WebSocket-1.3.0.tar.gz :
  CHECKSUM(SHA256) this package     : afab136090f8c3f3f4be3df2c9270342220d7e3b878e4f36daa7f11a442409a9
  CHECKSUM(SHA256) upstream package : afab136090f8c3f3f4be3df2c9270342220d7e3b878e4f36daa7f11a442409a9


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/bin/fedora-review -vpn Java-WebSocket -m fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Comment 10 gil cattaneo 2015-08-19 11:35:55 UTC 
APPROVED
Comment 11 Jonny Heggheim 2015-08-19 19:30:07 UTC 
New Package SCM Request
=======================
Package Name: Java-WebSocket
Short Description: A barebones WebSocket client and server implementation written in 100% Java
Upstream URL: http://java-websocket.org/
Owners: jonny
Branches: f23
Comment 12 Gwyn Ciesla 2015-08-20 13:32:41 UTC 
Git done (by process-git-requests).