Bug 1231742
| Summary: | nfs-ganesha: hardcoded value for parameter cidr_netmask=32 in ganesha-ha.sh script | ||
|---|---|---|---|
| Product: | [Red Hat Storage] Red Hat Gluster Storage | Reporter: | Saurabh <saujain> |
| Component: | nfs-ganesha | Assignee: | Kaleb KEITHLEY <kkeithle> |
| Status: | CLOSED WONTFIX | QA Contact: | Manisha Saini <msaini> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rhgs-3.1 | CC: | amukherj, jthottan, kkeithle, mzywusko, ndevos, nlevinki, rhs-bugs, sankarshan, skoduri, smohan |
| Target Milestone: | --- | Keywords: | FutureFeature, RFE, ZStream |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | Bug | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
The real issue was the '"' characters in the virt IP address that were causing the resource to not be created. Once the resource is successfully created with a virt IP address (without the '"'s) then things seem to be okay. The real issue was the '"' characters in the virt IP address that were causing the resource to not be created. Once the resource is successfully created with a virt IP address (without the '"'s) then things seem to be okay. Fixed by the patch for https://bugzilla.redhat.com/show_bug.cgi?id=1227311 I tested the things as per modified script i.e. ganesha-ha.sh(script under review), asn I was able to get the 8 node cluster running on one hypervisor. Though I am still not sure why we have to hardcode the value for cidr_netmask param, can't we take the same as input from config file? hard-coded 32 is not wrong AFAICT. a /32 netmask is normally a mistake. I believe that the resource agent will compute the correct netmask. The documentation says that if the cidr_netmask is not specified that it will compute the netmask from the interface. However if the cidr_netmask isn't specified then the resource create will fail. The documention shows using a value of 32. I infer that using 32 is okay and will compute the correct netmask. We could certainly add it to the /etc/ganesha/ganesha-ha.conf file if the above assumptions turn out to be incorrect. |
Description of problem: As per the script of ganesha-ha.sh script the cidr_netmask param is hardcoded and this is getting used at the time of resource creations. hard coded line from script, pcs -f ${cibfile} resource create ${1}-cluster_ip-1 ocf:heartbeat:IPaddr ip=${ipaddr} cidr_netmask=32 op monitor interval=15s The cidr_netmask may not always be "32"in customer scenarios. Highly likely because of this hard coded value I am getting a issue related to setting up cluster, as /var/log/messages report Jun 15 19:28:19 nfs11 IPaddr(nfs11-cluster_ip-1)[2872]: ERROR: IP address ["10.70.44.92"] not valid. We get this error during cluster setup and setup fails. From further triage I see that the ip assigned is with cidr "<ip>/22" not "<ip>/32". Version-Release number of selected component (if applicable): glusterfs-3.7.1-3.el6rhs.x86_64 nfs-ganesha-2.2.0-2.el6rhs.x86_64 How reproducible: always Expected results: parameters values should not be hard coded. Additional info: