Bug 1231771

Summary:	glusterd: Porting logging messages to new logging framework
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Nandaja Varma <nandaja.varma>
Component:	glusterd	Assignee:	Nandaja Varma <nvarma>
Status:	CLOSED ERRATA	QA Contact:	SATHEESARAN <sasundar>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rhgs-3.1	CC:	amukherj, kparthas, nlevinki, nsathyan, nvarma, rcyriac, sasundar, smohan, vagarwal, vbellur
Target Milestone:	---
Target Release:	RHGS 3.1.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.1-6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-07-29 05:03:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1202842, 1235991

Description Nandaja Varma 2015-06-15 11:49:23 UTC

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Nandaja Varma 2015-06-18 06:05:56 UTC


Description of problem:

The current implementation of logging is only available for some xlators.
The logging have to be implemented for glusterd for better reading of log file and consistency.

Version-Release number of selected component (if applicable):
RHGS 3.1

How reproducible:

N/A

Steps to Reproduce:
N/A

Actual results:

Unavailability of new logging mechanism (MSG ID) in glusterd.

Expected results:

Implement logging based on message ids for glusterd.

Comment 5 Atin Mukherjee 2015-06-18 10:07:42 UTC

https://code.engineering.redhat.com/gerrit/#/c/50910 (backport of master: http://review.gluster.org/10473) is merged now.

Comment 6 Atin Mukherjee 2015-06-18 11:16:07 UTC

https://code.engineering.redhat.com/gerrit/50888 (backport of master:http://review.gluster.org/9905) is merged now

Comment 7 Atin Mukherjee 2015-06-18 12:37:02 UTC

Downstream - https://code.engineering.redhat.com/gerrit/50896 (backport of master:http://review.gluster.org/#/c/9952/) is merged now

Comment 9 SATHEESARAN 2015-06-25 06:45:39 UTC

This patch for the fix is not complete and few other patches[http://review.gluster.org/#/c/11388/1] needs to be merged.

Marking this bug for the correct state

Comment 11 krishnan parthasarathi 2015-06-27 04:05:03 UTC

*** Bug 1235991 has been marked as a duplicate of this bug. ***

Comment 13 Nandaja Varma 2015-06-27 07:40:40 UTC

The last patch has been merged in downstream:
https://code.engineering.redhat.com/gerrit/#/c/51682/

Upstream links:
master: http://review.gluster.org/11388
release-3.7: http://review.gluster.org/11422

Comment 14 SATHEESARAN 2015-07-09 17:21:11 UTC

There are still 12 instances of gf_log instances seen in glusterd codebase.
But these are introduced by Anuradha Talur with the patch - https://code.engineering.redhat.com/gerrit/#/c/51017/

The changes are minimal and doesn't impact much.
Also all the patches mentioned in this bug ports most of gf_log to gf_msg messages

Created a new bug - https://bugzilla.redhat.com/show_bug.cgi?id=1241649 for pending changes

So marking this bug as VERIFIED for RHGS 3.1 release

Comment 15 errata-xmlrpc 2015-07-29 05:03:30 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-1495.html