Bug 1232572

Summary: quota: quota list displays double the size of previous value, post heal completion.
Product: [Community] GlusterFS Reporter: Vijaikumar Mallikarjuna <vmallika>
Component: quotaAssignee: Vijaikumar Mallikarjuna <vmallika>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: mainlineCC: annair, ashah, bugs, gluster-bugs, nsathyan, saujain, smohan, vagarwal, vmallika
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1178130
: 1233117 (view as bug list) Environment:
Last Closed: 2016-06-16 13:12:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1178130    
Bug Blocks: 1044344, 1202842, 1223636, 1233117    

Comment 1 Anand Avati 2015-06-17 05:09:37 UTC
REVIEW: http://review.gluster.org/11264 (quota: fix double accounting with rename operation) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 2 Anand Avati 2015-06-17 05:20:36 UTC
REVIEW: http://review.gluster.org/11264 (quota: fix double accounting with rename operation) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 3 Anand Avati 2015-06-17 11:27:56 UTC
REVIEW: http://review.gluster.org/11264 (quota: fix double accounting with rename operation) posted (#4) for review on master by Sachin Pandit (spandit)

Comment 4 Anand Avati 2015-06-18 06:20:17 UTC
REVIEW: http://review.gluster.org/11264 (quota: fix double accounting with rename operation) posted (#5) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 5 Anand Avati 2015-06-19 01:59:11 UTC
COMMIT: http://review.gluster.org/11264 committed in master by Vijay Bellur (vbellur) 
------
commit 81972918a0b0252cfa7feefbb80182fa886a72f8
Author: vmallika <vmallika>
Date:   Wed Jun 17 10:33:13 2015 +0530

    quota: fix double accounting with rename operation
    
    When a rename operation is performed, we are renaming
    the file first and performing remove-xattr when reducing
    the contri size from parents.
    This remove-xattr fails as the file is alreday renamed,
    this failure causes reduce-parent-size to abort resulting
    in double quota accounting
    
    This patch fixes the problem. We don't need to perform remove-xattr
    operation on a file when performing reduce-parent-size txn as this
    will be alreday done before starting reduce-parent-size txn
    
    Change-Id: If86e3dbb0233f6deaaa90bee72cb0ec1689c7325
    BUG: 1232572
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/11264
    Reviewed-by: Raghavendra G <rgowdapp>
    Tested-by: NetBSD Build System <jenkins.org>

Comment 6 Nagaprasad Sathyanarayana 2015-10-25 15:14:39 UTC
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 7 Niels de Vos 2016-06-16 13:12:44 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user