Bug 1232606
Summary: | Libvirt should forbid to create duplicate mpath pool | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Pei Zhang <pzhang> |
Component: | libvirt | Assignee: | John Ferlan <jferlan> |
Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 7.2 | CC: | dyuan, jferlan, mzhan, rbalakri, xuzhang, yanyang |
Target Milestone: | rc | ||
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | libvirt-1.2.17-1.el7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-11-19 06:41:25 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Pei Zhang
2015-06-17 07:10:43 UTC
According to http://libvirt.org/storage.html#StorageBackendMultipath the target element is ignored, something addressable in http://libvirt.org/formatstorage.html when describing valid target path values. Beyond that I also see no reason to support more than one mpath pool on a host. So I've sent patches upstream in order address this: http://www.redhat.com/archives/libvir-list/2015-June/msg01232.html http://www.redhat.com/archives/libvir-list/2015-June/msg01233.html The first just clarifies that target path is not used by the mpath storage driver. The second disallows two pools being defined on the same host. They may be combined into one if both are accepted. Patches pushed upstream: commit a77056bdb5d6d3942daf3f472d2dc3faa10bbe06 Author: John Ferlan <jferlan> Date: Wed Jun 24 08:45:24 2015 -0400 mpath: Don't allow more than one mpath pool at a time https://bugzilla.redhat.com/show_bug.cgi?id=1232606 Since an mpath pool contains all the Multipath devices on a host, allowing more than one defined on a host at a time should be disallowed under the policy of disallowing duplicate source pools for the host. Adjust to docs to clarify the Multipath target path value usage for both the storage driver (only 1 pool per host) and formatstorage references (ignore the target element in favor of the default target mapping of /dev/mapper). $ git describe a77056bdb5d6d3942daf3f472d2dc3faa10bbe06 v1.2.17-rc1-13-ga77056b $ Verified with libvirt-1.2.17-2.el7.x86_64 Steps 1. define/start a mpath pool with following xml # virsh pool-dumpxml mpathp <pool type='mpath'> <name>mpathp</name> <uuid>e405f824-d057-4b38-aa95-16d8d22d7176</uuid> <capacity unit='bytes'>21481278464</capacity> <allocation unit='bytes'>21481278464</allocation> <available unit='bytes'>0</available> <source> </source> <target> <path>/dev</path> </target> </pool> #virsh pool-define mpath.xml #virsh pool-start mpathp # virsh vol-list mpathp Name Path ------------------------------------------------------------------------------ dm-3 /dev/mapper/mpathb Note: a Multipath pool ignores the target element in favor of the default target mapping of /dev/mapper 2. define another mpath pool # virsh pool-define yy-mpath.xml error: Failed to define pool from yy-mpath.xml error: operation failed: Storage source conflict with pool: 'mpathp' Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-2202.html |