Bug 1233438

Summary: [RFE] Anaconda action for CDL formatting for LDL low level formatted disks.
Product: Red Hat Enterprise Linux 7 Reporter: Samantha N. Bueno <sbueno>
Component: python-blivetAssignee: Samantha N. Bueno <sbueno>
Status: CLOSED ERRATA QA Contact: Release Test Team <release-test-team-automation>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.1CC: bugproxy, ebrizuel, hannsj_uhl, jstodola, release-test-team-automation, salmy, sbueno
Target Milestone: rcKeywords: FutureFeature, Triaged
Target Release: 7.3   
Hardware: s390x   
OS: Linux   
Whiteboard:
Fixed In Version: python-blivet-0.61.15.46-1 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: 1170656 Environment:
Last Closed: 2016-11-03 23:49:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1170656, 1244833    
Bug Blocks: 1191019, 1214407, 1230910, 1232849, 1271742, 1428456    

Description Samantha N. Bueno 2015-06-18 23:08:54 UTC
+++ This bug was initially created as a clone of Bug #1170656 +++

+++ This bug was initially created as a clone of Bug #1164240 +++

Opening a new Feature Request as per https://bugzilla.redhat.com/show_bug.cgi?id=1144979#c4

1. Proposed title of this feature request  
Anaconda action for CDL formatting for LDL low level formatted disks. Might be possible by adding a particular parameter in kickstart?
      
3. What is the nature and description of the request?  
Red Hat only supports the CDL low level formatted disks in zlinux. The LDL formatted disks create problem during installation. kernel detects them and there partitions, whereas anaconda can't detect them. So it will be great if anaconda pop up a message with the help of dasdview output and state that there are few underlying disks with LDL format so that customers will know that there is a problem and they can fix the format.And beyond that, anaconda shall ask if customers want to fix this by CDL formatting, and if selected yes, format the Disks with CDL format.

4. Why does the customer need this? (List the business requirements here)  
This made alot of confusion about our support on CDL v/s LDL formatted disks. There are few softwares in zlinux which provides LDL formatted disks which manually need intervention to format with CDL.
      
5. How would the customer like to achieve this? (List the functional requirements here)  
By a pop up message by anaconda with few details and next steps of action, like dasdfmt with cdl format?
      
6. For each functional requirement listed, specify how Red Hat and the customer can test to confirm the requirement is successfully implemented.  
By a pop up message by anaconda with few details and next steps of action, like dasdfmt with cdl format? Or simply a pop up informational message.
      
7. Is there already an existing RFE upstream or in Red Hat Bugzilla?  
There is one _ONLY_ for warning Message https://bugzilla.redhat.com/show_bug.cgi?id=1144979

8. Does the customer have any specific timeline dependencies and which release would they like to target (i.e. RHEL5, RHEL6)?  
No
      
9. Is the sales team involved in this request and do they have any additional input?  
No
      
10. List any affected packages or components.  
Anaconda
      
11. Would the customer be able to assist in testing this functionality if implemented?  
Yes

--- Additional comment from Samantha N. Bueno on 2014-12-04 10:49:04 EST ---

FWIW, the same solution for 1164240 will be implemented here: 
clearpart will get a new option added to it to format LDL disks -> CDL

Comment 3 Jan Stodola 2015-10-08 18:29:04 UTC
Retested with python-blivet-0.61.15.34-1.el7, but also FBA DASDs are treated as LDL disks, which is not correct.
Since also other LDL bugs have been moved to 7.3 and this bug is not a blocker, proposing this bug for 7.3 and moving back to ASSIGNED.

Comment 7 Jan Stodola 2016-05-12 12:03:56 UTC
Anaconda still asks to format FBA devices, the following change is needed to fix that:

diff --git a/blivet/devicelibs/dasd.py b/blivet/devicelibs/dasd.py
index 5b5f64f..446908a 100644
--- a/blivet/devicelibs/dasd.py
+++ b/blivet/devicelibs/dasd.py
@@ -131,7 +131,7 @@ def is_ldl_dasd(device):
         return False
 
     # check we're not on an FBA DASD, since dasdfmt can't run on them
-    if arg.type[0:2] == 'FBA':
+    if arg.type[0:3] == 'FBA':
         return False
 
     # check DASD volume label; "VOL1" is CDL formatted DASD, won't

Tested with python-blivet-0.61.15.45-1.el7

Comment 10 Jan Stodola 2016-08-29 09:23:24 UTC
Anaconda no longer asks to format FBA disks, and detection and formatting of LDL disks works fine - tried in text and vnc mode, kickstart and manual installation.
Tested with anaconda-21.48.22.86-1.el7, pykickstart-1.99.66.10-1.el7, python-blivet-0.61.15.55-1.el7.

Thanks, moving to VERIFIED.

Comment 11 Jan Stodola 2016-09-01 12:49:17 UTC
*** Bug 1271742 has been marked as a duplicate of this bug. ***

Comment 13 errata-xmlrpc 2016-11-03 23:49:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2168.html