Bug 1233981

Summary: [GSS](6.1.z) Unable to split the connector name into two lines in BPM Suite 6.1
Product: [Retired] JBoss BPMS Platform 6 Reporter: Alessandro Lazarotti <alazarot>
Component: jBPM DesignerAssignee: Tihomir Surdilovic <tsurdilo>
Status: CLOSED EOL QA Contact: Jiri Locker <jlocker>
Severity: medium Docs Contact:
Priority: high    
Version: 6.1.0CC: ajuricic, alazarot, fspolti, kgaevski, kverlaen, mbaluch, smala, tsurdilo, wsiqueir
Target Milestone: CR2   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1225181 Environment:
Last Closed: 2020-03-27 20:03:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1225181    
Bug Blocks: 1230825    

Description Alessandro Lazarotti 2015-06-19 22:52:13 UTC
+++ This bug was initially created as a clone of Bug #1225181 +++

Description of problem:
It is not possible to split a connector name into two lines. After saving, everything is placed at the same line. See xx and yy.


Version-Release number of selected component (if applicable):
BPM Suite 6.1


How reproducible:
Always (firefox)


Steps to Reproduce:
1. Create a simple process and add a connector;
2. Name it and split the name into two lines (i.e. Sample Name)
3. Save , close and re-open the process.


Actual results:
Everything will be placed at the same line after saving.


Expected results:
It should still be splitted into two lines after saving/re-opening.

Comment 3 Tihomir Surdilovic 2015-06-22 16:01:01 UTC
For nodes that have a width+height (like tasks, subprocesses etc) the name text is placed inside the node. In these cases we do have the ability to 'fill" the space of the node with text and put the text within the boundaries of the node shape.

For Sequence Flows since they are lines we have to place the name above the line. There is no shape (with+height) so we have to place the text in a single line.

I tried a couple of options to fix this but none of them really look good. The best I could suggest for sequence flows is in the case a longer name is needed to make the sequence flow line long enough for that text to fit in.

Comment 4 Tihomir Surdilovic 2015-06-22 16:08:43 UTC
Just to add - there is always an option for the user to add a Text Annotation node to the sequence flows. This node is purely cosmetic and allows users to place additional text / description / explanation of certain nodes in the process.

This would be a great workaround for this issue as well.

Comment 6 Tihomir Surdilovic 2015-06-29 20:06:50 UTC
Fixed in Designer master and 6.2.x branches.

6.2.x commit https://github.com/droolsjbpm/jbpm-designer/commit/c5402f1eba56c063468bde9d3afd48d4a8c92b74

Please note that you have to use the Name property in the properties pannel in otder to set a multi-line name for sequence flows.

This is done for sequence flows and Tasks. For other nodes please raise a different BZ as their implementation will need a little different approach.

Comment 7 Alessandro Lazarotti 2015-06-30 13:08:22 UTC
This is appropriated thanks Tiho

Comment 8 Kirill Gaevskii 2015-07-07 17:51:24 UTC
SequenceFlow is splitted into two lines after saving/re-opening. But building of process fails with error:

ProcessLoadError: unable to parse xml : Exception class org.xml.sax.SAXParseException : <metaData> has an invalid parent element [SequenceFlow (_04D7C658-CA7D-4137-9C86-A1568359F3AE) [processStartEvent -> _55158B2B-F80F-40EE-9725-56465865423A]]

Comment 9 Tihomir Surdilovic 2015-07-08 15:52:48 UTC
Can you please tell me how I can reproduce your findings? I tried locally with master and 6.2.x branches and I tested on
http://hp-dl380pg8-01.lab.eng.brq.redhat.com:8100/kie-wb
without success. 

Where can I download the bits or what eng server can I use to see the issues?

Comment 10 Tihomir Surdilovic 2015-07-08 21:03:43 UTC
Found the issue - the jbpm parser currently does not allow extension elements (metadata) on sequence flows. We have a fix on jbpm master which is currently being evaluated. We will have more info on this very soon.

Comment 12 Marek Baluch 2015-07-09 06:25:11 UTC
Tiho - Thank you for digging into this issue!

Comment 13 Tihomir Surdilovic 2015-07-09 13:57:51 UTC
Fix commits (note they are jBPM commits, not Designer):

master: https://github.com/droolsjbpm/jbpm/commit/734a1957b

6.2.x: https://github.com/droolsjbpm/jbpm/commit/4c75d32b9bf4b5d8740c474b066ab4a99f9ce9b0