Bug 1234207

Summary: RFE: qjson support for Qt5
Product: [Fedora] Fedora Reporter: Raphael Groner <projects.rg>
Component: qjsonAssignee: Rex Dieter <rdieter>
Status: CLOSED DEFERRED QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: drizt72, jgrulich, projects.rg, rdieter
Target Milestone: ---Keywords: FutureFeature, Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-08 19:13:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Raphael Groner 2015-06-22 03:41:13 UTC
Description of problem:
Please provide support for Qt5.

Version-Release number of selected component (if applicable):
-

How reproducible:
-

Steps to Reproduce:
1. dnf install qjdns
2.
3.

Actual results:
Not possible to build any package with Qt5 and qjdns dependencies.

Expected results:
Package builds with Qt5 and qjdns dependencies.

Additional info:
Convention is to provide a package named qjdns-qt5 if qjdns is the main package that needs optional qt5 support.

Comment 1 Raphael Groner 2015-07-19 22:11:42 UTC
Any news here? Please be aware that this bug blocks a review and any further update of other package(s) cause qjson is used as a library.

Comment 2 Rex Dieter 2015-08-03 13:13:41 UTC
Working on it today.

Good news: upstream supports Qt5

Bad news: they seem to have fell in the trap of not making Qt5 builds parallel-installable :(

Comment 3 Rex Dieter 2015-08-03 13:26:46 UTC
Qt5 should have json support built-in now, a separate qjson should not be necessary, are you sure qt5 psi (still) needs this?

Comment 4 Rex Dieter 2015-08-03 13:37:42 UTC
See also,
https://github.com/flavio/qjson/issues/50

Comment 5 Rex Dieter 2015-08-07 15:09:18 UTC
It's not clear if this is really needed by qt5 psi or not yet... let's defer until we know for sure

Comment 6 Raphael Groner 2015-08-07 15:22:53 UTC
[17:15:03] <rdieter> confirmed that patches/dev/fix_historydb_qt5.diff references the QJson support built-in to qtbase-5.x already

This makes the RFE useless for now.

Comment 7 Rex Dieter 2015-11-08 04:27:53 UTC
%changelog
* Sat Nov 07 2015 Rex Dieter <rdieter> 0.8.1-12
- qjson-qt5(-devel) support (#1234207), use %%license tag

Comment 8 Raphael Groner 2015-11-08 06:33:17 UTC
https://raphgro.fedorapeople.org/copr/psi+/qjson-qt5-0-0.1.20150318gitd0f62e6.fc23.src.rpm

I did also some builds on Copr.

Comment 9 Rex Dieter 2015-11-08 07:15:38 UTC
Mind you, the qjson you used isn't parallel-installable with qt4 qjson either (ie, so users with fedora's qt4 qjson cannot use the copr build)

Comment 10 Raphael Groner 2015-11-08 08:37:18 UTC
What packages depend on qt4 build of qjson, except both psi and psi-plus?

Comment 11 Rex Dieter 2015-11-08 13:14:51 UTC
Lots:

$ repoquery --whatrequires qjson
amarok-0:2.8.0-17.fc23.x86_64
baloo-libs-0:4.14.3-5.fc23.x86_64
cantata-0:1.4.1-4.fc23.x86_64
choqok-0:1.5-3.fc23.x86_64
choqok-libs-0:1.5-3.fc23.x86_64
clementine-0:1.2.3-12.fc23.x86_64
contextkit-0:0.5.41-10.fc23.x86_64
kde-connect-kde4-libs-0:0.8-9.fc23.x86_64
kdenlive-0:0.9.10-1.fc22.x86_64
kdepim-libs-7:4.14.10-5.fc23.x86_64
kdepim-runtime-1:4.14.10-5.fc23.x86_64
kdepimlibs-akonadi-0:4.14.10-3.fc23.x86_64
kdevelop-libs-9:4.7.1-10.fc23.x86_64
kdevelop-libs-9:4.7.2-1.fc23.x86_64
kdevplatform-libs-0:1.7.1-5.fc23.x86_64
kdevplatform-libs-0:1.7.2-1.fc23.x86_64
kipi-plugins-0:4.13.0-1.fc23.x86_64
kmail-libs-0:4.14.10-5.fc23.x86_64
libechonest-0:2.3.0-3.fc23.x86_64
libkfbapi-0:1.0-6.fc23.x86_64
libkgapi-0:2.2.0-4.fc23.x86_64
libkscreen-1:1.0.5-4.fc23.x86_64
libkvkontakte-0:4.13.0-1.fc23.x86_64
libmygpo-qt-0:1.0.8-4.fc23.x86_64
okular-libs-0:15.04.2-2.fc23.x86_64
openambit-0:0.3-9.git5f2b784.fc23.x86_64
plasma-widget-menubar-0:0.2.0-5.fc23.x86_64
psi-plus-1:0.16-0.21.20141205git440.fc23.x86_64
qbittorrent-1:3.2.4-2.fc23.x86_64
qbittorrent-nox-1:3.2.4-2.fc23.x86_64
qjson-devel-0:0.8.1-10.fc23.x86_64
qtweetlib-0:0.5-10.fc23.x86_64
skrooge-0:1.11.0-2.fc23.1.x86_64
skrooge-libs-0:1.11.0-2.fc23.1.x86_64
tellico-0:2.3.10-3.fc23.x86_64
tomahawk-0:0.8.4-5.fc23.x86_64
tomahawk-libs-0:0.8.4-5.fc23.x86_64
yarock-0:0.9.67-5.fc23.x86_64

Comment 12 Ivan Romanov 2015-11-08 17:40:06 UTC
psi-plus should/must/allready use json support from Qt5.

Comment 13 Raphael Groner 2015-11-08 18:40:07 UTC
Ivan, I don't understand your comment. psi-plus package was built in the review with qt4 libraries. Wow, did you manage to use qt5 and how?

Comment 14 Rex Dieter 2015-11-08 19:13:33 UTC
I'm getting confused too with the back-n-forth.  

So is this needed or not? 

I'm going with not, unless told otherwise, and making -qt5 support optional, but disabled

Comment 15 Raphael Groner 2015-11-09 06:21:03 UTC
Sorry, I did not want to confuse anyone and introduce unnecessary work load.
Qt5 support of Psi+ is actually optional and needed only for an inofficial Copr build of mine.

Comment 16 Ivan Romanov 2015-11-09 06:37:41 UTC
https://github.com/psi-plus/main/blob/master/patches/dev/fix_historydb_qt5.diff#L26
psi-plus Qt5 version is not depends from qjson.