Bug 1234664

Informal review:

https://fedorahosted.org/released/javapackages/doc/

This section, isn't guaranteed to work:

```
# overwrite bundled libs with symlinks to system libraries
ln -sfn /usr/share/java/xmlgraphics-commons.jar jchart2d/ext/xmlgraphics-commons-1.3.1.jar
ln -sfn /usr/share/java/jide-oss.jar jchart2d/ext/jide-oss-2.9.7.jar
ln -sfn /usr/share/java/proguard/proguard.jar jchart2d/ext/build/proguard-4.5.1.jar
ln -sfn /usr/share/java/junit.jar jchart2d/ext/build/junit-4.8.1.jar
```

Something should probably be done in %build and these libs removed in %prep
http://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires


I understand the need to override the jars, as that is a fedora requirement, but your BuildDepends could be any version, which could cause problems depending on which version is installed.

Run fedora-review locally to see other errors:
`dnf install -y fedora-review fedora-review-plugin-java`
`fedora-review -b 1234664`

You will see errors and warnings such as:

Rpmlint
-------
Checking: jchart2d-3.2.2-1.fc23.noarch.rpm
          jchart2d-javadoc-3.2.2-1.fc23.noarch.rpm
          jchart2d-3.2.2-1.fc23.src.rpm
jchart2d.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory # i'm not sure why this python call is here ?
jchart2d.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

(In reply to Brian Demers from comment #1)
> This section, isn't guaranteed to work:
> 
> ```
> # overwrite bundled libs with symlinks to system libraries
> ln -sfn /usr/share/java/xmlgraphics-commons.jar
> jchart2d/ext/xmlgraphics-commons-1.3.1.jar
> ln -sfn /usr/share/java/jide-oss.jar jchart2d/ext/jide-oss-2.9.7.jar
> ln -sfn /usr/share/java/proguard/proguard.jar
> jchart2d/ext/build/proguard-4.5.1.jar
> ln -sfn /usr/share/java/junit.jar jchart2d/ext/build/junit-4.8.1.jar
> ```
> 
> Something should probably be done in %build and these libs removed in %prep
> http://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires
> 
> 
> I understand the need to override the jars, as that is a fedora requirement,
> but your BuildDepends could be any version, which could cause problems
> depending on which version is installed.

Sorry, I'm not sure what you're suggesting I do here?

Yes you're right that the Fedora packaged versions of those dependencies might not exactly match the bundled jars, but that's a perpetual problem we have with Fedora Java packages. So long as it builds and works with the current Fedora versions, we're okay. If it doesn't I will patch it.

If you mean, the symlinks are lying about the actual version numbers of the dependency jars we are using... yes that's true, but unfortunately the build.xml has all the dependency jar filenames hardcoded and it didn't seem worthwhile to patch it to remove those.

> Run fedora-review locally to see other errors:
> `dnf install -y fedora-review fedora-review-plugin-java`
> `fedora-review -b 1234664`
> 
> You will see errors and warnings such as:
> 
> Rpmlint
> -------
> Checking: jchart2d-3.2.2-1.fc23.noarch.rpm
>           jchart2d-javadoc-3.2.2-1.fc23.noarch.rpm
>           jchart2d-3.2.2-1.fc23.src.rpm
> jchart2d.noarch: W: no-documentation
> 3 packages and 0 specfiles checked; 0 errors, 1 warnings.

I don't see any problem here. The upstream tarball has no other docs aside from the license.

Re: jars, I'm just noting that this is problematic.

For the doc / license issue open a bug upstream if you haven't already and put a note in the spec.

Same might work out for the classpath problem, at least so it is tracked.

hi
can you use:
find . -name "*.class" -delete
find . -name "*.jar" -delete
instead of hard coded directories
ln -sfn /usr/share/java/junit.jar jchart2d/ext/build/junit-4.8.1.jar
ln -sf $(build-classpath junit) jchart2d/ext/build/junit-4.8.1.jar
(even for the remaining artifacts)

?

regards

I have emailed Dan, I will close the ticket and open a new one.