Bug 1235007

Summary:	Allow only lookup and delete operation on file that is in split-brain
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	replicate	Assignee:	Ravishankar N <ravishankar>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	asrivast, bugs, gluster-bugs, nsathyan, ssampat
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1223738
Clones:	1235934 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:15:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1223738
Bug Blocks:	1202842, 1223636, 1235934

Description Ravishankar N 2015-06-23 17:58:03 UTC

+++ This bug was initially created as a clone of Bug #1223738 +++

Description of problem:
------------------------

Any operations on a file that is in data or meta-data split-brain should not be allowed, with the exception of lookups and deletes. 

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
glusterfs-3.7.0-2.el6rhs.x86_64

How reproducible:
------------------
N/A

Steps to Reproduce:
--------------------
N/A

Actual results:
----------------

Operations other than lookup and delete (like stat, truncate etc.) are allowed on files in split-brain.

Expected results:
------------------

Allow only lookup and delete on a file that is in split-brain.

Additional info:

--- Additional comment from Red Hat Bugzilla Rules Engine on 2015-05-21 07:21:25 EDT ---

This bug is automatically being proposed for Red Hat Gluster Storage 3.2.0 by setting the release flag 'rhgs‑3.2.0' to '?'. 

If this bug should be proposed for a different release, please manually change the proposed release flag.

--- Additional comment from Rejy M Cyriac on 2015-06-08 08:07:30 EDT ---

Setting Target Release to RHGS 3.1.0 as this BZ has the release flag rhgs-3.1.0+

Comment 1 Anand Avati 2015-06-23 18:00:51 UTC

REVIEW: http://review.gluster.org/11371 (afr: Block fops when file is in split-brain) posted (#1) for review on master by Ravishankar N (ravishankar)

Comment 2 Anand Avati 2015-06-25 07:31:42 UTC

REVIEW: http://review.gluster.org/11371 (afr: Block fops when file is in split-brain) posted (#2) for review on master by Ravishankar N (ravishankar)

Comment 3 Anand Avati 2015-06-26 02:30:10 UTC

REVIEW: http://review.gluster.org/11371 (afr: Block fops when file is in split-brain) posted (#4) for review on master by Ravishankar N (ravishankar)

Comment 4 Anand Avati 2015-06-26 05:40:59 UTC

REVIEW: http://review.gluster.org/11371 (afr: Block fops when file is in split-brain) posted (#5) for review on master by Ravishankar N (ravishankar)

Comment 5 Anand Avati 2015-06-26 06:00:21 UTC

REVIEW: http://review.gluster.org/11371 (afr: Block fops when file is in split-brain) posted (#6) for review on master by Ravishankar N (ravishankar)

Comment 6 Anand Avati 2015-06-26 07:27:11 UTC

REVIEW: http://review.gluster.org/11371 (afr: Block fops when file is in split-brain) posted (#7) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 7 Anand Avati 2015-06-27 02:30:50 UTC

COMMIT: http://review.gluster.org/11371 committed in master by Vijay Bellur (vbellur) 
------
commit 0104b5869d89ac58cb13e10417626455c8ba2143
Author: Ravishankar N <ravishankar>
Date:   Thu Jun 25 00:22:41 2015 +0530

    afr: Block fops when file is in split-brain
    
    For directories, block metadata FOPS.
    For non-directories, block data and metadata FOPS.
    Do not block entry FOPS.
    
    Change-Id: Id7f656f4a513b9d33c457dd7f2d58028dbef8e61
    BUG: 1235007
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/11371
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: NetBSD Build System <jenkins.org>

Comment 8 Nagaprasad Sathyanarayana 2015-10-25 14:44:40 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 9 Niels de Vos 2016-06-16 13:15:21 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user