Bug 1235403

Summary: [RFE] Check physical ram addressing limit when hotplugging
Product: Red Hat Enterprise Linux 8 Reporter: Dr. David Alan Gilbert <dgilbert>
Component: qemu-kvmAssignee: Ani Sinha <anisinha>
qemu-kvm sub component: Devices QA Contact: Mario Casquero <mcasquer>
Status: CLOSED CURRENTRELEASE Docs Contact:
Severity: low    
Priority: low CC: ailan, anisinha, imammedo, jinzhao, juzhang, mdeng, nilal, qzhang, rbalakri, virt-maint, xfu, yuhuang
Version: 8.1Keywords: FutureFeature, Improvement, Reopened
Target Milestone: rc   
Target Release: 8.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-09-19 13:05:39 UTC Type: Story
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dr. David Alan Gilbert 2015-06-24 17:32:47 UTC
Description of problem:
Paolo says we don't check the physical addressing limit (36...46 bits etc) when hot adding RAM.  That's probably bad.

Version-Release number of selected component (if applicable):


How reproducible:
Not tried.

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 5 Ademar Reis 2020-02-05 22:42:17 UTC
QEMU has been recently split into sub-components and as a one-time operation to avoid breakage of tools, we are setting the QEMU sub-component of this BZ to "General". Please review and change the sub-component if necessary the next time you review this BZ. Thanks

Comment 8 RHEL Program Management 2020-11-01 03:02:41 UTC
After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.

Comment 9 Yumei Huang 2020-11-19 02:18:09 UTC
Hi Igor, 

The bug is auto closed. Would you please double check if the issue is not going to be fixed? Otherwise, I guess we need reopen it. Thanks!

Comment 11 Mario Casquero 2023-07-13 08:33:59 UTC
Hello Igor,

Do you still plan to take any action on this bz? Thanks!

Comment 12 Igor Mammedov 2023-07-14 08:12:15 UTC
(In reply to Mario Casquero from comment #11)
> Hello Igor,
> 
> Do you still plan to take any action on this bz? Thanks!

I think Ani plans to look into it he has some spare time

Comment 13 Mario Casquero 2023-07-20 07:24:35 UTC
Hello,

Should we consider include the RFE keyword as this is some kind of 'enhancement'?

Comment 14 Ani Sinha 2023-07-20 07:30:31 UTC
(In reply to Mario Casquero from comment #13)
> Hello,
> 
> Should we consider include the RFE keyword as this is some kind of
> 'enhancement'?

Yes.

Comment 17 Ani Sinha 2023-09-19 13:05:39 UTC
There is already processor address space check present for 64-bit guests as well as 32-bit/ < 32-bit. 
There can be some improvements for 32-bit.

Please see upstream threads:

https://www.mail-archive.com/qemu-devel@nongnu.org/msg987201.html
https://www.mail-archive.com/qemu-devel@nongnu.org/msg989957.html
https://lists.gnu.org/archive/html/qemu-devel/2023-09/msg04796.html

for details.

Marking this as CLOSED/WORKSFORME.

Comment 18 Mario Casquero 2023-09-20 05:56:30 UTC
Hello Ani,

As far as I can see, WORKSFORME resolutions are used when the problem described is not a bug and they should not be used for Red Hat Enterprise Linux bugs[1].
In this case, you have provided 3 upstream patches that can solve this bz.

What about changing the resolution to something more appropriate like CURRENTRELEASE?
Thanks!

[1] https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_status

Comment 19 Ani Sinha 2023-09-20 07:31:52 UTC
(In reply to Mario Casquero from comment #18)
> Hello Ani,
> 
> As far as I can see, WORKSFORME resolutions are used when the problem
> described is not a bug and they should not be used for Red Hat Enterprise
> Linux bugs[1].
> In this case, you have provided 3 upstream patches that can solve this bz.


No they are upstream discussion and not patches. I have not pushed any patches upstream and I don't think anything needs fixing for x86_64.
CURRENTRELEASE is fine with me.

Comment 20 Mario Casquero 2023-09-20 07:37:28 UTC
> No they are upstream discussion and not patches. I have not pushed any
> patches upstream and I don't think anything needs fixing for x86_64.
> CURRENTRELEASE is fine with me.

My fault, I saw patch word in the title :)
Thanks for updating the resolution!