Bug 1235810

Summary: Ripright confuses MUSICBRAINZ_ALBUMID and MUSICBRAINZ_RELEASEGROUPID
Product: [Fedora] Fedora Reporter: Marc Ponschab <marc>
Component: riprightAssignee: Christopher Meng <i>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 22CC: i, marc
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: ripright-0.11-1.fc23 ripright-0.11-1.fc22 ripright-0.11-1.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-31 00:55:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch which fixes the bug none

Description Marc Ponschab 2015-06-25 19:22:33 UTC
Created attachment 1043270 [details]
Patch which fixes the bug

Description of problem:

Ripright confuses MUSICBRAINZ_ALBUMID and MUSICBRAINZ_RELEASEGROUPID

Version-Release number of selected component (if applicable):

0.9

How reproducible:

Rip a CD which Disc-Id is attached to a CD in the MusicBrainz database. Ripright writes the ReleaseGroupId to the tag MUSICBRAINZ_ALBUMID, so the album is not recognized by MusicBrainz Picard (eg. after encoding the flac files to ogg). It should write the ReleaseId to the tag MUSICBRAINZ_ALBUMID.  

Steps to Reproduce:

1. Rip a CD which Disc-Id is attached to a CD in the MusicBrainz database.
2. Drag the ripped flac files in MusicBrainz Picard to the "Unmatched Files" folder in the right-hand pane.  

Actual results:

MusicBrainz Picard tries to load a album, but it fails (the server responds 404 not found).

Expected results:

MusicBrainz Picard loads the album, which ripright has identified by the Disc-Id.


Additional info:

I've attached a patch for version 0.9, which modifies Ripright to write the ReleaseId to the tag MUSICBRAINZ_ALBUMID and the ReleaseGroupId to the tag MUSICBRAINZ_RELEASEGROUPID.

With the patch applied, ripright-tagged albums are recognized by MusicBrainz Picard quite fine.

I'm opening the bug here, as the upstream is not reachable (E-Mail is bouncing).

Comment 1 Fedora Update System 2015-12-20 04:27:16 UTC
ripright-0.11-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-c927c62c9b

Comment 2 Fedora Update System 2015-12-20 04:27:24 UTC
ripright-0.11-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-48752120b5

Comment 3 Fedora Update System 2015-12-22 15:33:54 UTC
ripright-0.11-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-53ca2c1c70

Comment 4 Fedora Update System 2015-12-23 00:11:45 UTC
ripright-0.11-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-c927c62c9b

Comment 5 Fedora Update System 2015-12-24 05:21:23 UTC
ripright-0.11-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-48752120b5

Comment 6 Fedora Update System 2015-12-31 00:55:55 UTC
ripright-0.11-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2015-12-31 01:50:27 UTC
ripright-0.11-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2016-01-17 21:59:10 UTC
ripright-0.11-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.