Bug 1236270

Summary: [Backup]: File movement across directories does not get captured in the output file in a X3 volume
Product: [Community] GlusterFS Reporter: Saravanakumar <sarumuga>
Component: glusterfindAssignee: Kotresh HR <khiremat>
Status: CLOSED CURRENTRELEASE QA Contact: bugs <bugs>
Severity: medium Docs Contact:
Priority: unspecified    
Version: mainlineCC: avishwan, khiremat, mchangir, nsathyan, sanandpa
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1228247
: 1236282 (view as bug list) Environment:
Last Closed: 2016-06-16 13:17:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1228247    
Bug Blocks: 1223636, 1236282    

Comment 1 Saravanakumar 2015-06-27 05:54:47 UTC
Given the verbose nature of bug, posting the main issue lately faced:

Modify OLD
Rename OLD NEW

           ==> Currently recorded as (bug!)
                            MODIFY NEW    
                            RENAME NEW NEW.

Comment 2 Kotresh HR 2015-06-27 09:30:04 UTC
Description of problem:
When a file is moved from its original location to another directory, with the same name or with a different name, the change does not get captured in the output file. File rename at the same location does not get recorded as well. 

Do note that this issue is seen intermittently in a replica 3 volume.

However on a replica 2 volume, every file movement (across directories) gets recorded as a MODIFY entry and a rename (also) gets recorded as a MODIFY entry (bug 1227691)

Version-Release number of selected component (if applicable):


How reproducible: Always


Steps to Reproduce:
1. Create a replica 3 volume 'cross3' and a glusterfind session
2. Mount the volume over nfs/fuse and create 2 files 'test1' and 'test2' and a directory 'dir1'
3. Execute glusterfind pre and verify that 3 NEW entries are seen in the output file
4. Move the file 'test1' to dir1/test1 and run glusterfind pre and post
5. Output file shows a MODIFY entry for dir1/test1
6. Rename the file 'test2' to 'newtest2' and run glusterfind pre and post
7. Output file remains empty, without logging in any change
8. Move the file 'dir1/test1' to its original location, this time with a change in name. Run glusterfind pre and post
9. Output file again remains empty.

Comment 3 Anand Avati 2015-06-27 09:31:40 UTC
REVIEW: http://review.gluster.org/11443 (tools/glusterfind: RENAME and MODIFY issues) posted (#1) for review on master by Kotresh HR (khiremat)

Comment 4 Anand Avati 2015-06-27 18:55:59 UTC
REVIEW: http://review.gluster.org/11443 (tools/glusterfind: RENAME and MODIFY issues) posted (#2) for review on master by Kotresh HR (khiremat)

Comment 5 Anand Avati 2015-06-28 03:56:43 UTC
REVIEW: http://review.gluster.org/11443 (tools/glusterfind: RENAME and MODIFY issues) posted (#3) for review on master by Kotresh HR (khiremat)

Comment 6 Anand Avati 2015-06-28 04:23:36 UTC
REVIEW: http://review.gluster.org/11443 (tools/glusterfind: RENAME and MODIFY issues) posted (#4) for review on master by Kotresh HR (khiremat)

Comment 7 Anand Avati 2015-06-28 08:35:21 UTC
REVIEW: http://review.gluster.org/11443 (tools/glusterfind: RENAME and MODIFY issues) posted (#5) for review on master by Niels de Vos (ndevos)

Comment 8 Anand Avati 2015-06-28 11:22:08 UTC
REVIEW: http://review.gluster.org/11443 (tools/glusterfind: RENAME and MODIFY issues) posted (#7) for review on master by Kotresh HR (khiremat)

Comment 9 Anand Avati 2015-06-30 08:18:51 UTC
REVIEW: http://review.gluster.org/11443 (tools/glusterfind: RENAME and MODIFY issues) posted (#8) for review on master by Milind Changire (mchangir)

Comment 10 Anand Avati 2015-07-03 05:10:20 UTC
REVIEW: http://review.gluster.org/11443 (tools/glusterfind: RENAME and MODIFY issues) posted (#9) for review on master by Kotresh HR (khiremat)

Comment 11 Anand Avati 2015-07-06 06:09:13 UTC
COMMIT: http://review.gluster.org/11443 committed in master by Venky Shankar (vshankar) 
------
commit adc704557a141a624fc702f7303b8b81582e1598
Author: Aravinda VK <avishwan>
Date:   Fri Jun 26 22:36:31 2015 -0400

    tools/glusterfind: RENAME and MODIFY issues
    
    If Modification happens before RENAME, GFID to Path Conversion
    converts it into New Path. Delete Modify Entry and insert again
    So that MODIFY <NEW NAME> comes after RENAME.
    
    Default value of pgfids and basenames changed to "" instead of NULL
    Also fixed RENAME issue of displaying "RENAME <NEW NAME> <NEW NAME>".
    Also fixed RENAME followed by missing MODIFY
    
    Change-Id: I8202f6e6ec33f7bd921e71da38677f2ee2dab87a
    BUG: 1236270
    Signed-off-by: Kotresh HR <khiremat>
    Signed-off-by: Milind Changire <mchangir>
    Reviewed-on: http://review.gluster.org/11443
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Aravinda VK <avishwan>
    Tested-by: NetBSD Build System <jenkins.org>

Comment 12 Nagaprasad Sathyanarayana 2015-10-25 15:04:39 UTC
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 13 Niels de Vos 2016-06-16 13:17:51 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user