Bug 1236511

Summary: Review Request: jredis - Java Client and Connectors for Redis
Product: [Fedora] Fedora Reporter: gil cattaneo <puntogil>
Component: Package ReviewAssignee: Eduardo Mayorga <e>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: e, package-review
Target Milestone: ---Flags: e: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: jredis-2.0.0-0.1.a.0.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-08-07 13:06:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1228203    

Description gil cattaneo 2015-06-29 09:42:04 UTC
Spec URL: https://gil.fedorapeople.org/jredis.spec
SRPM URL: https://gil.fedorapeople.org/jredis-a.0-0.1.fc20.src.rpm
Description:
The Core module is composed of all the core elements that
are used to create JRedis clients and connectors for the
Redis server.
Fedora Account System Username: gil

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10237348

Comment 2 Eduardo Mayorga 2015-07-27 01:14:14 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
=======
- The versioning seems incorrect. According to the information in their Google Code page, the latest release is 2.0.0. Also, according to the Naming Guidelines, non-numeric characters may be included in the release field.
  See: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Version_Tag

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 286720 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It
     is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
     when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jredis-
     core , jredis-core-api , jredis-core-bench , jredis-core-ri , jredis-
     javadoc
[x]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: jredis-a.0-0.1.fc24.noarch.rpm
          jredis-core-a.0-0.1.fc24.noarch.rpm
          jredis-core-api-a.0-0.1.fc24.noarch.rpm
          jredis-core-bench-a.0-0.1.fc24.noarch.rpm
          jredis-core-ri-a.0-0.1.fc24.noarch.rpm
          jredis-javadoc-a.0-0.1.fc24.noarch.rpm
          jredis-a.0-0.1.fc24.src.rpm
jredis-core-bench.noarch: W: no-documentation
jredis-core-ri.noarch: W: no-documentation
7 packages and 0 specfiles checked; 0 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
jredis.noarch: W: invalid-url URL: https://github.com/alphazero/jredis <urlopen error [Errno -5] No address associated with hostname>
jredis-core-ri.noarch: W: invalid-url URL: https://github.com/alphazero/jredis <urlopen error [Errno -5] No address associated with hostname>
jredis-core-ri.noarch: W: no-documentation
jredis-core-bench.noarch: W: invalid-url URL: https://github.com/alphazero/jredis <urlopen error [Errno -5] No address associated with hostname>
jredis-core-bench.noarch: W: no-documentation
jredis-core.noarch: W: invalid-url URL: https://github.com/alphazero/jredis <urlopen error [Errno -5] No address associated with hostname>
jredis-core-api.noarch: W: invalid-url URL: https://github.com/alphazero/jredis <urlopen error [Errno -5] No address associated with hostname>
jredis-javadoc.noarch: W: invalid-url URL: https://github.com/alphazero/jredis <urlopen error [Errno -5] No address associated with hostname>
6 packages and 0 specfiles checked; 0 errors, 8 warnings.



Requires
--------
jredis (rpmlib, GLIBC filtered):
    java-headless
    jpackage-utils
    mvn(org.apache.maven.plugins:maven-compiler-plugin)

jredis-core-ri (rpmlib, GLIBC filtered):
    java-headless
    jpackage-utils
    mvn(commons-logging:commons-logging)
    mvn(log4j:log4j:1.2.17)
    mvn(org.jredis:jredis-core-api)

jredis-core-bench (rpmlib, GLIBC filtered):
    java-headless
    jpackage-utils
    mvn(org.jredis:jredis-core-api)
    mvn(org.jredis:jredis-core-ri)

jredis-core (rpmlib, GLIBC filtered):
    java-headless
    jpackage-utils
    mvn(org.apache.maven.plugins:maven-surefire-plugin)
    mvn(org.jredis:jredis:pom:)

jredis-core-api (rpmlib, GLIBC filtered):
    java-headless
    jpackage-utils
    mvn(commons-logging:commons-logging)
    mvn(log4j:log4j:1.2.17)

jredis-javadoc (rpmlib, GLIBC filtered):
    jpackage-utils



Provides
--------
jredis:
    jredis
    mvn(org.jredis:jredis:pom:)

jredis-core-ri:
    jredis-core-ri
    mvn(org.jredis:jredis-core-ri)
    mvn(org.jredis:jredis-core-ri:pom:)

jredis-core-bench:
    jredis-core-bench
    mvn(org.jredis:jredis-core-bench)
    mvn(org.jredis:jredis-core-bench:pom:)

jredis-core:
    jredis-core
    mvn(org.jredis:jredis-core:pom:)

jredis-core-api:
    jredis-core-api
    mvn(org.jredis:jredis-core-api)
    mvn(org.jredis:jredis-core-api:pom:)

jredis-javadoc:
    jredis-javadoc



Source checksums
----------------
https://github.com/alphazero/jredis/archive/0eed7931ea0aa827fe74dfa808467c16e12d6e96/jredis-0eed7931ea0aa827fe74dfa808467c16e12d6e96.tar.gz :
  CHECKSUM(SHA256) this package     : 5ccb127b357fcd56f8d621c7e8a161ea0c1a92f2ccb1ea9c3a1f6d475b0d1df1
  CHECKSUM(SHA256) upstream package : 5ccb127b357fcd56f8d621c7e8a161ea0c1a92f2ccb1ea9c3a1f6d475b0d1df1

Comment 3 gil cattaneo 2015-07-27 08:12:04 UTC
(In reply to Eduardo Mayorga from comment #2)
> Issues:
> =======
> - The versioning seems incorrect. According to the information in their
> Google Code page, the latest release is 2.0.0. Also, according to the Naming
> Guidelines, non-numeric characters may be included in the release field.
>   See: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Version_Tag

Spec URL: https://gil.fedorapeople.org/jredis.spec
SRPM URL: https://gil.fedorapeople.org/jredis-2.0.0-0.1.a.0.fc22.src.rpm

Comment 4 gil cattaneo 2015-07-27 16:40:42 UTC
Eduardo Ping ...

Comment 5 Eduardo Mayorga 2015-07-27 18:14:37 UTC
Now it looks fine.

PACKAGE APPROVED

Comment 6 gil cattaneo 2015-07-27 18:20:05 UTC
Thanks!

New Package SCM Request
=======================
Package Name: jredis
Short Description: Java Client and Connectors for Redis
Upstream URL: https://github.com/alphazero/jredis
Owners: gil
Branches: f22 f23
InitialCC: java-sig

Comment 7 Gwyn Ciesla 2015-07-27 19:17:40 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2015-07-27 20:41:08 UTC
jredis-2.0.0-0.1.a.0.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/jredis-2.0.0-0.1.a.0.fc22

Comment 9 Fedora Update System 2015-07-30 01:19:04 UTC
jredis-2.0.0-0.1.a.0.fc22 has been pushed to the Fedora 22 testing repository.

Comment 10 Fedora Update System 2015-08-07 13:06:22 UTC
jredis-2.0.0-0.1.a.0.fc22 has been pushed to the Fedora 22 stable repository.