Bug 1236588

Summary: Disable ovirt-host-deploy packager plugins while deploying HE
Product: [oVirt] ovirt-hosted-engine-setup Reporter: Sandro Bonazzola <sbonazzo>
Component: GeneralAssignee: Simone Tiraboschi <stirabos>
Status: CLOSED CURRENTRELEASE QA Contact: Artyom <alukiano>
Severity: medium Docs Contact:
Priority: high    
Version: 1.3.0CC: bugs, gklein, lsurette, mavital, michal.skrivanek, rbalakri, stirabos, yeylon, ykaul, ylavi
Target Milestone: ovirt-3.6.2Keywords: Triaged
Target Release: 1.3.2Flags: rule-engine: ovirt-3.6.z+
ylavi: planning_ack+
sbonazzo: devel_ack+
mavital: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: hosted-engine-setup, when the engine is ready, asks to the engine to add the host via API. By default host-deploy packager plugin is active and can upgrade qemu packages while the engine VM is running. Consequence: Due to a qemu update while the engine VM is running, the engnien VM can crash. Fix: Disable host-deploy packager plugin when adding an host triggered by hosted-engine-setup. Result: host-deploy will not upgrade rpms. It's up to the user to put the host in maintenance mode and manually upgrade after that if needed.
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-11 07:21:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Sandro Bonazzola 2015-06-29 13:28:19 UTC
According to virt team having ovirt-host-deploy able to update kvm or system library may cause a crash in HE VM.
So the packager plugins must be disabled while deploying hosted engine.

Comment 1 Sandro Bonazzola 2015-09-11 14:24:51 UTC
The merged patch add the needed deps, still missing the code for disabling the packager during the deployment.

Comment 2 Red Hat Bugzilla Rules Engine 2015-10-19 11:03:20 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 3 Sandro Bonazzola 2015-10-27 12:34:09 UTC
Michal can you describe what an update may break here? the reason for disabling the packager.

Comment 4 Michal Skrivanek 2015-10-27 12:39:19 UTC
IIRC this was quite some time ago when updated caused the crash... in general this can happen anytime as you are basically replacing a running process' binaries and libraries, and in some cases this can immediately crash the VM. It's a bad practice...that's what the Maintenance mode is good for
The only concern is with upgrading any system component while HE(or any VM) is currently running on the host.

Comment 5 Yaniv Lavi 2015-10-29 12:18:52 UTC
In oVirt testing is done on single release by default. Therefore I'm removing the 4.0 flag. If you think this bug must be tested in 4.0 as well, please re-add the flag. Please note we might not have testing resources to handle the 4.0 clone.

Comment 6 Yaniv Kaul 2015-12-03 15:03:30 UTC
Any updates to this bug? (it's marked as high priority)

Comment 7 Simone Tiraboschi 2015-12-03 17:47:25 UTC
Posted.

Comment 8 Simone Tiraboschi 2015-12-04 10:57:48 UTC
The proposed patch disable host-deploy packager and so we are sure that host-deploy will not upgrade qemu or libvirt or vdsm while the engine VM is running to be sure that the upgrade will not kill it.
But at the end it will still be up to the user to upgrade the host after that.

On the opposite side, we could also check that all the packages are up to date before deploying and ask the user to upgrade if not.

Comment 9 Artyom 2016-02-25 11:28:07 UTC
Verified on ovirt-hosted-engine-setup-1.3.3.4-1.el7ev.noarch
1) Start deploy with old packages of vdsm and qemu
2) Update host to have repo with new vdsm and qemu
3) finish deploy and check that host still have old packages