Bug 1238391
| Summary: | Lifecycle/customize root password logged in clear text. | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Josh Carter <jocarter> |
| Component: | Automate | Assignee: | Keenan Brock <kbrock> |
| Status: | CLOSED ERRATA | QA Contact: | Kyrylo Zvyagintsev <kzvyahin> |
| Severity: | medium | Docs Contact: | |
| Priority: | high | ||
| Version: | 5.4.0 | CC: | jhardy, kzvyahin, mfeifer, mkanoor, obarenbo, snansi, tfitzger |
| Target Milestone: | GA | ||
| Target Release: | 5.5.0 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Fixed In Version: | 5.5.0.1 | Doc Type: | Bug Fix |
| Doc Text: |
In the previous version of CloudForms Management Engine, providing a root password in the Customize tab while provisioning a virtual machine resulted in the password being logged in clear text to the evm log. This was because the method used to dump object data did not define the filters for sensitive data. This bug was fixed by adding the filter options to the object dump method. The root password is no longer logged while provisioning a virtual machine in the new version of CloudForms Management Engine.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-12-08 13:21:02 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Josh Carter
2015-07-01 18:35:03 UTC
The dumpObj method allows for a options hash which can define "protected" filters. This needs to be implemented in the calls where we are dumping the provision options. See /vmdb/app/models/miq_provision_vmware/cloning.rb and vmdb/app/models/miq_provision_task_configured_system_foreman/options_helper.rb for examples. The workflow has a class method that defines the protected fields for a task (self.encrypted_options_fields) which we might want to use to ensure new fields are hidden if they are added. The workflow could be loaded from the task using the MiqProvisionWorkflow.class_for_source(source) method. New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/58e3ffcaef48b7e662a6341f49378c7399f3f4b0 commit 58e3ffcaef48b7e662a6341f49378c7399f3f4b0 Author: Keenan Brock <kbrock> AuthorDate: Mon Jul 6 16:02:59 2015 -0400 Commit: Keenan Brock <kbrock> CommitDate: Tue Jul 7 10:53:25 2015 -0400 Don't log provisioning passwords from options leverage workflow's encryption_option_fields to filter options sent to dumpObject https://bugzilla.redhat.com/show_bug.cgi?id=1238391 app/models/miq_provision_amazon/cloning.rb | 2 +- app/models/miq_provision_microsoft/cloning.rb | 2 +- app/models/miq_provision_openstack/cloning.rb | 2 +- app/models/miq_provision_redhat/cloning.rb | 2 +- app/models/miq_provision_vmware/cloning.rb | 2 +- app/models/miq_request_workflow.rb | 4 ++++ app/models/mixins/miq_provision_mixin.rb | 6 +++++- spec/models/miq_provision_redhat_spec.rb | 16 ++++++++++++++++ 8 files changed, 30 insertions(+), 6 deletions(-) Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2015:2551 |