Bug 1238709

Summary: Redeploy of hosted-engine on NFS storage failed
Product: Red Hat Enterprise Virtualization Manager Reporter: Artyom <alukiano>
Component: ovirt-hosted-engine-setupAssignee: Simone Tiraboschi <stirabos>
Status: CLOSED WONTFIX QA Contact: Artyom <alukiano>
Severity: high Docs Contact:
Priority: medium    
Version: 3.6.0CC: bmcclain, ecohen, gklein, lsurette, sbonazzo, stirabos, ylavi
Target Milestone: ---Keywords: Triaged
Target Release: 3.6.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: integration
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-01 11:40:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
sos report none

Description Artyom 2015-07-02 12:54:48 UTC 
Created attachment 1045504 [details]
sos report

Description of problem:
We have possibility to continue deployment with exist vm, how described in bug https://bugzilla.redhat.com/show_bug.cgi?id=1002454.
So I run deployment first time, and stop it(CTRL+D) after OS installation OS.
After I kill vm(vdsClient -s 0 destroy vm_id) and re-run deployment(hosted-engine --config-append=answer_file_from_first_deployment), but deployment failed with error:
[ ERROR ] Failed to execute stage 'Misc configuration': Wrong Master domain or its version: 'SD=829741c6-b01d-44c7-8bf7-3b75ed5fb2f2, pool=00000000-0000-0000-0000-000000000000'


Version-Release number of selected component (if applicable):
ovirt-hosted-engine-setup-1.3.0-0.0.master.20150623153111.git68138d4.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1. See above
2.
3.

Actual results:
re-deploy of hosted engine failed

Expected results:
re-deploy must success and continue deployment with VM from first deployment

Additional info:
See sos report for logs
Comment 1 Simone Tiraboschi 2015-07-29 08:17:10 UTC 
The feature was quite interesting when we don't have the appliance cause the deployment process was really long (hours) and so being able to restart from a partially deployed system was an interesting option to save time in case of deployment errors.
Now deploying hosted-engine with the engine appliance deployment takes just a few minutes and so it's not more that relevant.

The trick was booting from CDROM image and suddenly exit without touching the previously installed OS.
With the appliance is not applicable anymore cause re-deploying it will be always overwriting the previously written appliance and so the process is not that different than deploying from scratch on a clean storage domain.

At the same time re-deploying on dirty storage can be risky and error prone cause we don't have the full control on previously partially created structure.

So don't seeing anymore benefits and seeing it as risky, I'm proposing to avoid supporting the redeploy on partially deployed storage simply asking to the user to cleanup the storage and try again. 
Yaniv, what do you think about that?
Comment 2 Yaniv Lavi 2015-08-09 16:24:11 UTC 
(In reply to Simone Tiraboschi from comment #1)
> The feature was quite interesting when we don't have the appliance cause the
> deployment process was really long (hours) and so being able to restart from
> a partially deployed system was an interesting option to save time in case
> of deployment errors.
> Now deploying hosted-engine with the engine appliance deployment takes just
> a few minutes and so it's not more that relevant.
> 
> The trick was booting from CDROM image and suddenly exit without touching
> the previously installed OS.
> With the appliance is not applicable anymore cause re-deploying it will be
> always overwriting the previously written appliance and so the process is
> not that different than deploying from scratch on a clean storage domain.
> 
> At the same time re-deploying on dirty storage can be risky and error prone
> cause we don't have the full control on previously partially created
> structure.
> 
> So don't seeing anymore benefits and seeing it as risky, I'm proposing to
> avoid supporting the redeploy on partially deployed storage simply asking to
> the user to cleanup the storage and try again. 
> Yaniv, what do you think about that?

In appliance flow there is no point in this and since there is no user request, I would no allow partial for manual as well. If requested, we can consider this.
Comment 3 Simone Tiraboschi 2015-08-11 08:37:30 UTC 
I perfectly agree: now with the appliance it can be really dangerous cause you are going to overwrite the previously deployed engine VM completely destroying your system so I prefer to explicitly disallow it to prevent any possible mistake for who is running the setup script again in the need for update.
Comment 4 Artyom 2015-09-01 11:40:51 UTC 
Stop support of redeploy feature from 3.6 according to https://bugzilla.redhat.com/show_bug.cgi?id=1238709#c2