Bug 1238737

Summary: libstoragemgmt: should return error code when command fails
Product: Red Hat Enterprise Linux 7 Reporter: Bruno Goncalves <bgoncalv>
Component: libstoragemgmtAssignee: Gris Ge <fge>
Status: CLOSED ERRATA QA Contact: Bruno Goncalves <bgoncalv>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.2CC: tasleson
Target Milestone: rcKeywords: Regression, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-19 11:46:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Bruno Goncalves 2015-07-02 13:49:59 UTC
Description of problem:
When lsmcli executes a command and fails it should return an error code

Version-Release number of selected component (if applicable):
libstoragemgmt-1.2.3-2.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
# lsmcli  -u
usage: lsmcli [-h] [-v] [-u <URI>] [-P] [-H] [-t <SEP>] [-e] [-f] [-w WAIT]
              [--header] [-b] [-s]
              command ...
lsmcli: error: argument -u/--uri: expected one argument

# echo $?
0

Actual results:
return 0

Expected results:
should return value different of 0

Comment 1 Bruno Goncalves 2015-07-02 13:51:12 UTC
With previous version it works

libstoragemgmt-1.1.0-2.el7.x86_64

# lsmcli  -u
usage: lsmcli [-h] [-v] [-u <URI>] [-P] [-H] [-t <SEP>] [-e] [-f] [-w WAIT]
              [--header] [-b] [-s]
              command ...
lsmcli: error: argument -u/--uri: expected one argument

# echo $?
2

Comment 5 Bruno Goncalves 2015-09-02 08:19:30 UTC
Verified with libstoragemgmt-1.2.3-3.el7

# lsmcli  -u
usage: lsmcli [-h] [-v] [-u <URI>] [-P] [-H] [-t <SEP>] [-e] [-f] [-w WAIT]
              [--header] [-b] [-s]
              command ...
lsmcli: error: argument -u/--uri: expected one argument

# echo $?
2

Comment 6 errata-xmlrpc 2015-11-19 11:46:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2015-2342.html