Bug 1238755

*** Bug 1129677 has been marked as a duplicate of this bug. ***

Taking for review.

Here's rpmlint output:

$ rpmlint gstreamer1-rtsp-server-1.4.0-3.fc23.src.rpm \
          gstreamer1-rtsp-server \
          gstreamer1-rtsp-server-devel \
          gstreamer1-rtsp-server-devel-docs \
          gstreamer1-rtsp-server-debuginfo

gstreamer1-rtsp-server.src: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer
gstreamer1-rtsp-server.src:98: W: macro-in-%changelog %make_install
gstreamer1-rtsp-server.x86_64: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer
gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libgstbase-1.0.so.0
gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libgstrtp-1.0.so.0
gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libpthread.so.0
gstreamer1-rtsp-server-devel.x86_64: W: only-non-binary-in-usr-lib
gstreamer1-rtsp-server-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 8 warnings.

Most of it is noise, but the "W: macro-in-%changelog %make_install" issue would be important to fix. rpm expands macros anywhere, even in the %changelog section and that means it also expands the %make_install macro, messing up the changelog section.

Easiest would be to either escape the macro with %% or just remove the % macro symbol in front of it.


Some other things I noticed while going through the spec file; none of those are review blockers but might be nice to fix:

> %build
> # Until https://bugzilla.gnome.org/show_bug.cgi?id=634376 is fixed, disable introspection
> %configure  --enable-gtk-doc

I think this comment can go? Introspection seems to be enabled in the build now.


> find %{buildroot} -name '*.a' -exec rm -f {} ';'

passing --disable-static to %configure would probably be slightly nicer than building the static library and then deleting it afterwards


> %doc COPYING.LIB README TODO NEWS

COPYING.LIB should be marked %license as per latest guideline updates. Not sure TODO is useful to package at all?


> %dir %{_libdir}/girepository-%{majorminor}/
> %{_libdir}/girepository-%{majorminor}/GstRtspServer-%{majorminor}.typelib

and

%files devel
%dir %{_datadir}/gir-%{majorminor}/
%{_datadir}/gir-%{majorminor}/GstRtspServer-%{majorminor}.gir

The girepository-1.0 and gir-1.0 directory versions are the gobject introspection version and using the rtsp-server's majorminor here is probably wrong. I'd just write 1.0 instead of using the macro.


> %files devel-docs
> %doc %{_datadir}/gtk-doc/html/gst-rtsp-server-%{majorminor}

Should include the %{_datadir}/gtk-doc/ and %{_datadir}/gtk-doc/html/ directories in the package as well to avoid leaving unowned directories behind on uninstall.

Thanks for review, I uploaded a new version that should fix all issues you reported.

Spec URL: http://people.freedesktop.org/~wtay/SPECS/gstreamer1-rtsp-server.spec
SRPM URL: http://people.freedesktop.org/~wtay/SRPMS/gstreamer1-rtsp-server-1.4.0-4.fc22.src.rpm

Fedora review gstreamer1-rtsp-server-1.4.0-4.fc22.src.rpm 2015-07-27

$ rpmlint gstreamer1-rtsp-server-1.4.0-4.fc22.src.rpm \
          gstreamer1-rtsp-server \
          gstreamer1-rtsp-server-debuginfo \
          gstreamer1-rtsp-server-devel gstreamer1-rtsp-server-devel-docs
gstreamer1-rtsp-server.src: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer
gstreamer1-rtsp-server.x86_64: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer
gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libgstbase-1.0.so.0
gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libgstrtp-1.0.so.0
gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libpthread.so.0
gstreamer1-rtsp-server-devel.x86_64: W: only-non-binary-in-usr-lib
gstreamer1-rtsp-server-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 7 warnings.

+ OK
! needs attention

+ rpmlint warnings are harmless and can be ignored
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The license text (COPYING.LIB) is included in %license
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match the sources in the srpm
  974af05dbf867cade89b8d3101e3f197  gst-rtsp-server-1.4.0.tar.xz
  974af05dbf867cade89b8d3101e3f197  Download/gst-rtsp-server-1.4.0.tar.xz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a locale handling
+ ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all the directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
+ Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect the runtime of application
n/a Static libraries should be in -static
+ Development files should be in -devel
+ -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8


Looks good to me.

APPROVED

New Package SCM Request
=======================
Package Name: gstreamer1-rtsp-server
Short Description: A GStreamer based RTSP server library
Upstream URL: http://gstreamer.freedesktop.org/
Owners: wtaymans
Branches: f22 f23 epel7
InitialCC: wtaymans

Git done (by process-git-requests).

Is now in f23 and rawhide.