Bug 1240376 (php-guzzlehttp-psr7)
| Summary: | Review Request: php-guzzlehttp-psr7 - PSR-7 message implementation | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, package-review | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | php-guzzlehttp-psr7-1.1.0-3.el7 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-07-30 01:13:46 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1239252 | ||||||||
| Attachments: |
|
||||||||
|
Description
Shawn Iwinski
2015-07-06 17:53:03 UTC
Also a new dependency of php-aws-sdk 3 Also a new dependency of php-aws-sdk 3 - Added autoloader dependencies - Modified autoloader Spec URL: https://raw.githubusercontent.com/siwinski/rpms/612b3107e9f64a02f8d670056709cacf76bc0250/php-guzzlehttp-psr7/php-guzzlehttp-psr7.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-guzzlehttp-psr7-1.1.0-2.fc22.src.rpm Fixed spec url. Spec URL: https://raw.githubusercontent.com/siwinski/rpms/c8c55cd1452d902b590a56914acf1dcd3cc8cbb0/php-guzzlehttp-psr7/php-guzzlehttp-psr7.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-guzzlehttp-psr7-1.1.0-2.fc22.src.rpm Created attachment 1052222 [details]
phpci.log
phpCompatInfo version 4.4.0 DB built Jul 13 2015 09:14:16 CEST static analyze results
Created attachment 1052223 [details]
review.txt
Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
PErhaps better to use full patch for symfony
- require_once 'Symfony/Component/ClassLoader/ClassLoader.php';
+ require_once '%{phpdir}/Symfony/Component/ClassLoader/ClassLoader.php';
Everything looks good.
No blocker
=== APPROVED ===
(In reply to Remi Collet from comment #7) > PErhaps better to use full patch for symfony > > - require_once 'Symfony/Component/ClassLoader/ClassLoader.php'; > + require_once > '%{phpdir}/Symfony/Component/ClassLoader/ClassLoader.php'; Thanks for catching that. I knew I had a few non-full paths in autoloaders out there :/ I'll update after initial import. New Package SCM Request ======================= Package Name: php-guzzlehttp-psr7 Short Description: PSR-7 message implementation Upstream URL: https://github.com/guzzle/psr7 Owners: siwinski Branches: f21 f22 epel7 InitialCC: Git done (by process-git-requests). php-guzzlehttp-psr7-1.1.0-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-guzzlehttp-psr7-1.1.0-3.fc21 php-guzzlehttp-psr7-1.1.0-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/php-guzzlehttp-psr7-1.1.0-3.fc22 php-guzzlehttp-psr7-1.1.0-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/php-guzzlehttp-psr7-1.1.0-3.el7 php-guzzlehttp-psr7-1.1.0-3.el7 has been pushed to the Fedora EPEL 7 testing repository. php-guzzlehttp-psr7-1.1.0-3.fc21 has been pushed to the Fedora 21 stable repository. php-guzzlehttp-psr7-1.1.0-3.fc22 has been pushed to the Fedora 22 stable repository. php-guzzlehttp-psr7-1.1.0-3.el7 has been pushed to the Fedora EPEL 7 stable repository. |