Bug 1240634
| Summary: | Review Request: python-afl - Module that enables Afl fork server for Python code | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Cyprian <mcyprian> |
| Component: | Package Review | Assignee: | Robert Kuska <rkuska> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jberan, package-review, panemade, rkuska |
| Target Milestone: | --- | Flags: | rkuska:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-09-03 09:03:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michal Cyprian
2015-07-07 11:59:53 UTC
1. It is not needed to define __python2 and python2_sitearch macros at the top of your specfile, they are already defined and ready to use
2. You miss a LICENSE file, this file is missing also in upstream, you should add LICENSE file as a new Source also consider reporting this to upstream, from packaging guidelines[0]:
"If the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %license. If the source package does not include the text of the license(s), the packager should contact upstream and encourage them to correct this mistake."
3. You don't list %doc files - README.rst changelog and trophy-case.rst
4. There is a macro in comment
"# %check section was not included, because properly working test" you should escape your macro or remove it from comment
5. Your summaries are too long, make them shorter :-)
6. Description line at python3 subpackage is also too long
7. Use %{_bindir} macro at %files section
8. Changelog is in a wrong format, correct format is:
* Tue Jul 07 2015 Michal Cyprian <mcyprian> - 0.2-1
9. .so files shipped by your rpms seems to have wrong file permissions 775, you can use rpm files directive to solve this - %defattr(755, root, root, -)[1]
[0]https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines
[1]http://www.rpm.org/max-rpm-snapshot/s1-rpm-specref-files-list-directives.html
Thank you for feed back. I've fixed all mentioned problems. I hope Spec file is now correct. Here are updated versions of files: Spec URL: https://mstuchli.fedorapeople.org/python-afl.spec SRPM URL: https://mstuchli.fedorapeople.org/python-afl-0.2-1.fc22.src.rpm Approved. New Package SCM Request ======================= Package Name: python-afl Short Description: Module that enables Afl fork server for Python code Upstream URL: https://pypi.python.org/pypi/python-afl/ Owners: mcyprian Branches: f22 f23 InitialCC: Git done (by process-git-requests). python-afl-0.2-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-afl-0.2-1.fc22 python-afl-0.2-1.fc22 has been pushed to the Fedora 22 testing repository. |